Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 14284010: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Split apart ForOffset into ForJSObjectOffset, ForJSArrayOffset, and ForFixedArrayOffset Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | src/hydrogen-instructions.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 arguments()->PrintTo(stream); 371 arguments()->PrintTo(stream);
372 stream->Add(" length "); 372 stream->Add(" length ");
373 length()->PrintTo(stream); 373 length()->PrintTo(stream);
374 stream->Add(" index "); 374 stream->Add(" index ");
375 index()->PrintTo(stream); 375 index()->PrintTo(stream);
376 } 376 }
377 377
378 378
379 void LStoreNamedField::PrintDataTo(StringStream* stream) { 379 void LStoreNamedField::PrintDataTo(StringStream* stream) {
380 object()->PrintTo(stream); 380 object()->PrintTo(stream);
381 stream->Add("."); 381 stream->Add(".@%d", offset()); // TODO(titzer): use HObjectAccess
382 stream->Add(*String::cast(*name())->ToCString());
383 stream->Add(" <- "); 382 stream->Add(" <- ");
384 value()->PrintTo(stream); 383 value()->PrintTo(stream);
385 } 384 }
386 385
387 386
388 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) { 387 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) {
389 object()->PrintTo(stream); 388 object()->PrintTo(stream);
390 stream->Add("."); 389 stream->Add(".");
391 stream->Add(*String::cast(*name())->ToCString()); 390 stream->Add(*String::cast(*name())->ToCString());
392 stream->Add(" <- "); 391 stream->Add(" <- ");
(...skipping 2228 matching lines...) Expand 10 before | Expand all | Expand 10 after
2621 2620
2622 2621
2623 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2622 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2624 LOperand* object = UseRegister(instr->object()); 2623 LOperand* object = UseRegister(instr->object());
2625 LOperand* index = UseRegister(instr->index()); 2624 LOperand* index = UseRegister(instr->index());
2626 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2625 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2627 } 2626 }
2628 2627
2629 2628
2630 } } // namespace v8::internal 2629 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | src/hydrogen-instructions.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698