Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 14284010: Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Make constructor of HObjectAccess and HObjectAccess::Portion private. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/hydrogen-instructions.cc ('K') | « src/stub-cache.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 if (is_double) { 393 if (is_double) {
394 return LDoubleStackSlot::Create(index, zone()); 394 return LDoubleStackSlot::Create(index, zone());
395 } else { 395 } else {
396 return LStackSlot::Create(index, zone()); 396 return LStackSlot::Create(index, zone());
397 } 397 }
398 } 398 }
399 399
400 400
401 void LStoreNamedField::PrintDataTo(StringStream* stream) { 401 void LStoreNamedField::PrintDataTo(StringStream* stream) {
402 object()->PrintTo(stream); 402 object()->PrintTo(stream);
403 stream->Add("."); 403 stream->Add(".@%d", offset()); // TODO(titzer): use HObjectAccess
404 stream->Add(*String::cast(*name())->ToCString());
405 stream->Add(" <- "); 404 stream->Add(" <- ");
406 value()->PrintTo(stream); 405 value()->PrintTo(stream);
407 } 406 }
408 407
409 408
410 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) { 409 void LStoreNamedGeneric::PrintDataTo(StringStream* stream) {
411 object()->PrintTo(stream); 410 object()->PrintTo(stream);
412 stream->Add("."); 411 stream->Add(".");
413 stream->Add(*String::cast(*name())->ToCString()); 412 stream->Add(*String::cast(*name())->ToCString());
414 stream->Add(" <- "); 413 stream->Add(" <- ");
(...skipping 2141 matching lines...) Expand 10 before | Expand all | Expand 10 after
2556 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2555 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2557 LOperand* object = UseRegister(instr->object()); 2556 LOperand* object = UseRegister(instr->object());
2558 LOperand* index = UseTempRegister(instr->index()); 2557 LOperand* index = UseTempRegister(instr->index());
2559 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2558 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2560 } 2559 }
2561 2560
2562 2561
2563 } } // namespace v8::internal 2562 } } // namespace v8::internal
2564 2563
2565 #endif // V8_TARGET_ARCH_X64 2564 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/hydrogen-instructions.cc ('K') | « src/stub-cache.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698