Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts

src/hydrogen-instructions.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3634 matching lines @@
   ASSERT(HasNoUses());
 }
 
 
 void HCheckFunction::Verify() {
   HInstruction::Verify();
   ASSERT(HasNoUses());
 }
 
 #endif
 

[danno, 2013/05/02 14:16:47]

nit: 2 lines

[titzer, 2013/05/03 09:18:41]

Done.

+void HObjectAccess::SetGVNFlags(HValue *instr, bool is_store) {
+  // set the appropriate GVN flags for a given load or store instruction
+  if (!is_store) {

[danno, 2013/05/02 14:16:47]

Why not just switch the else and then blocks so it's "if (is_store)"

[titzer, 2013/05/03 09:18:41]

Done.

+    instr->SetFlag(HValue::kUseGVN);    // try to GVN loads
+    instr->SetGVNFlag(kDependsOnMaps);  // but don't hoist above map changes
+  } else {
+    // track dominating allocations in order to eliminate write barriers
+    instr->SetGVNFlag(kDependsOnNewSpacePromotion);
+    instr->SetFlag(HValue::kTrackSideEffectDominators);
+  }
+
+  switch (portion_) {
+  case kArrayLengths:

[danno, 2013/05/02 14:16:47]

Weird indentation. Elsewhere in the code we use 2-char indents for cases, please
use that here, too.

[titzer, 2013/05/03 09:18:41]

Done.

+    instr->SetGVNFlag(
+        is_store ? kChangesArrayLengths : kDependsOnArrayLengths);
+    break;
+  case kInobject:
+    instr->SetGVNFlag(
+        is_store ? kChangesInobjectFields : kDependsOnInobjectFields);
+    break;
+  case kBackingStore:
+    instr->SetGVNFlag(
+        is_store ? kChangesBackingStoreFields : kDependsOnBackingStoreFields);
+    break;
+  case kElementsPointer:
+    instr->SetGVNFlag(
+        is_store ? kChangesElementsPointer : kDependsOnElementsPointer);
+    break;
+  case kMaps:
+    instr->SetGVNFlag(
+        is_store ? kChangesMaps : kDependsOnMaps);
+    break;
+  }
+}
+
 } }  // namespace v8::internal