Introduce HObjectAccess, which is used by LoadNamedField and StoreNamedField to denote what parts

src/code-stubs-hydrogen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 350 matching lines @@
     flags = static_cast<HAllocate::Flags>(
        flags | HAllocate::CAN_ALLOCATE_IN_OLD_POINTER_SPACE);
   }
   HInstruction* object =
       AddInstruction(new(zone) HAllocate(context(),
                                          size_in_bytes,
                                          HType::JSObject(),
                                          flags));
 
   for (int i = 0; i < size; i += kPointerSize) {
+    ObjectAccess access = AccessInobject(factory->empty_string(), i);

[danno, 2013/04/26 09:39:38]

Instead of taking the field name, I think this version should take a map, in
this case it should be context->object_function()->initial_map(). The logic
inside AccessInObject should be able to map to a string if it needs it.

[titzer, 2013/04/30 15:56:47]

Sure. Deferring this change to the follow-up CL.

     HInstruction* value =
-        AddInstruction(new(zone) HLoadNamedField(boilerplate, true, i));
-    AddInstruction(new(zone) HStoreNamedField(object,
-                                              factory->empty_string(),
-                                              value,
-                                              true, i));
+      AddInstruction(new(zone) HLoadNamedField(boilerplate, access));
+    AddStore(object, access, value);
   }
 
   checker.ElseDeopt();
   return object;
 }
 
 
 Handle<Code> FastCloneShallowObjectStub::GenerateCode() {
   return DoGenerateCode(this);
 }
@@ skipping 34 matching lines @@
 HValue* CodeStubGraphBuilder<TransitionElementsKindStub>::BuildCodeStub() {
   Zone* zone = this->zone();
 
   HValue* js_array = GetParameter(0);
   HValue* map = GetParameter(1);
 
   info()->MarkAsSavesCallerDoubles();
 
   AddInstruction(new(zone) HTrapAllocationMemento(js_array));
 
-  HInstruction* array_length =
-      AddInstruction(HLoadNamedField::NewArrayLength(
-            zone, js_array, js_array, HType::Smi()));
+  HInstruction* array_length = AddInstruction(
+        new(zone) HLoadNamedField(js_array, AccessArrayLength()));
+  array_length->set_type(HType::Smi());
 
   ElementsKind to_kind = casted_stub()->to_kind();
   BuildNewSpaceArrayCheck(array_length, to_kind);
 
   IfBuilder if_builder(this);
 
   if_builder.IfCompare(array_length, graph()->GetConstant0(), Token::EQ);
   if_builder.Then();
 
   // Nothing to do, just change the map.
 
   if_builder.Else();
 
   HInstruction* elements =
       AddInstruction(new(zone) HLoadElements(js_array, js_array));
 
   HInstruction* elements_length =
       AddInstruction(new(zone) HFixedArrayBaseLength(elements));
 
   HValue* new_elements =
       BuildAllocateAndInitializeElements(context(), to_kind, elements_length);
 
   BuildCopyElements(context(), elements,
                     casted_stub()->from_kind(), new_elements,
                     to_kind, array_length, elements_length);
 
-  Factory* factory = isolate()->factory();
-
-  AddInstruction(new(zone) HStoreNamedField(js_array,
-                                            factory->elements_field_string(),
-                                            new_elements, true,
-                                            JSArray::kElementsOffset));
+  AddStore(js_array, AccessElements(), new_elements);
 
   if_builder.End();
 
-  AddInstruction(new(zone) HStoreNamedField(js_array, factory->length_string(),
-                                            map, true, JSArray::kMapOffset));
+  AddStore(js_array, AccessMap(), map);
+
   return js_array;
 }
 
 
 Handle<Code> TransitionElementsKindStub::GenerateCode() {
   return DoGenerateCode(this);
 }
 
 
 template <>
@@ skipping 58 matching lines @@
       ? graph()->GetConstantSmi1()
       : graph()->GetConstantUndefined();
 }
 
 
 Handle<Code> CompareNilICStub::GenerateCode() {
   return DoGenerateCode(this);
 }
 
 } }  // namespace v8::internal