third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp - Issue 1428383002: Make ResourceFetcher::m_documentResources use WeakPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Issue 1428383002: Make ResourceFetcher::m_documentResources use WeakPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add TODOs Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

index eb017f008f1094cd01ae0f8f84582aa3d2a731e7..34171461fdc36f5325885632efe96afb27f6b65a 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

@@ -430,6 +430,8 @@ static void cachedResourcesForDocument(Document* document, WillBeHeapVector<RawP

const ResourceFetcher::DocumentResourceMap& allResources = document->fetcher()->allResources();

for (const auto& resource : allResources) {

Resource* cachedResource = resource.value.get();

+ if (!cachedResource)

+ continue;

switch (cachedResource->type()) {

case Resource::Image: