third_party/WebKit/Source/core/fetch/Resource.h - Issue 1428383002: Make ResourceFetcher::m_documentResources use WeakPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 1428383002: Make ResourceFetcher::m_documentResources use WeakPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/long-script-content.html ('k') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/Resource.h

diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h

index 39bca1c02587c2975803b9a363188661e8339d1c..3e0e285af2435c26c969e028f62e2a947570f10f 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.h

+++ b/third_party/WebKit/Source/core/fetch/Resource.h

@@ -265,6 +265,8 @@ public:

static const char* resourceTypeToString(Type, const FetchInitiatorInfo&);

+ WeakPtrWillBeRawPtr<Resource> asWeakPtr();

sof 2015/12/15 12:29:43 Add a TODO about removing this once Oilpan ships?

Nate Chapin 2015/12/15 20:30:59 Done.

#ifdef ENABLE_RESOURCE_IS_DELETED_CHECK

void assertAlive() const { RELEASE_ASSERT(!m_deleted); }

#else

@@ -382,6 +384,10 @@ private:

String m_fragmentIdentifierForRequest;

+#if !ENABLE(OILPAN)

+ WeakPtrFactory<Resource> m_weakPtrFactory;

+#endif

RefPtr<CachedMetadata> m_cachedMetadata;

OwnPtrWillBeMember<CacheHandler> m_cacheHandler;