Network Setup from Shark to Remora.

chrome/browser/chromeos/login/screens/network_screen.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/screens/network_screen.h"
 
+#include "base/json/json_writer.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/base/locale_util.h"
 #include "chrome/browser/chromeos/customization/customization_document.h"
 #include "chrome/browser/chromeos/login/help_app_launcher.h"
 #include "chrome/browser/chromeos/login/helper.h"
 #include "chrome/browser/chromeos/login/screen_manager.h"
 #include "chrome/browser/chromeos/login/screens/base_screen_delegate.h"
 #include "chrome/browser/chromeos/login/screens/network_view.h"
 #include "chrome/browser/chromeos/login/ui/input_events_blocker.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/webui/chromeos/login/l10n_util.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/network/network_handler.h"
+#include "chromeos/network/network_state.h"
 #include "chromeos/network/network_state_handler.h"
+#include "chromeos/network/network_util.h"
 #include "content/public/browser/browser_thread.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace {
 
 // Time in seconds for connection timeout.
 const int kConnectionTimeoutSec = 40;
 
 }  // namespace
 
@@ skipping 183 matching lines @@
   if (current_timezone_id == timezone_id)
     return;
   timezone_ = timezone_id;
   CrosSettings::Get()->SetString(kSystemTimezone, timezone_id);
 }
 
 std::string NetworkScreen::GetTimezone() const {
   return timezone_;
 }
 
+std::string NetworkScreen::GetConnectedWifiNetwork() {
+  // Currently We can only transfer unsecured WiFi configuration from Shark to
+  // Remora. There is no way to get password for a secured Wifi network in Cros
+  // for security reasons.
+  const NetworkState* network_state =
+      NetworkHandler::Get()->network_state_handler()->ConnectedNetworkByType(
+          NetworkTypePattern::WiFi());
+
+  if (!network_state)
+    return std::string();
+
+  scoped_ptr<base::DictionaryValue> current_onc =
+      network_util::TranslateNetworkStateToONC(network_state);
+  std::string security;
+  current_onc->GetString(
+      onc::network_config::WifiProperty(onc::wifi::kSecurity), &security);
+  if (security.compare(onc::wifi::kSecurityNone) != 0) {

[achuithb, 2015/11/05 23:26:12]

don't need {}

Why not 
if (security != onc::wifi:kSecurityNone)

[stevenjb, 2015/11/05 23:48:25]

+1

[xdai1, 2015/11/06 23:23:02]

Done.

+    return std::string();

[stevenjb, 2015/11/05 23:48:25]

Eventually, we could support WEP/WPA/PSK networks (which just require a
passphrase) by requesting the password from the host. We don't need to do this
now, but we should make sure that the code structure will be able to support
that.

[xdai1, 2015/11/06 23:23:02]

The Hotrod shark/remora (a.k.a, controller/host) project has been suspended. I'm
just trying to reuse some host side code for the new bootstrapping project. So I
think we only need to make sure that the code structure of the host side in Cros
can support creating and applying ONC network configuration to itself (which is
done by NetworkScreen::CreateAndApplyNetworkFromOnc() function), because the ONC
network configuration will be passed to the host Cros device from an Android
App. And the Android App probably can get the password by asking it from the
admin anyway. The shark side in Cros is basically for testing purpose to make
sure the entire flow work as intended. It would be great if we can also support
the secured network for the shark side, but I think it might not a high priority
task. Wdyt?

+  }
+
+  const std::vector<uint8_t> raw_ssid = network_state->raw_ssid();

[achuithb, 2015/11/05 23:26:12]

Why not GetHexSsid?
https://code.google.com/p/chromium/codesearch#chromium/src/chromeos/network/n...

[stevenjb, 2015/11/05 23:48:25]

+1

[xdai1, 2015/11/06 23:23:02]

Done. But it seems more complicated than just using raw_ssid directly.

[stevenjb, 2015/11/06 23:32:12]

Sorry, the suggestion was to use network_state->GetHexSsid() which returns a
string.

+  const std::string ssid(raw_ssid.begin(), raw_ssid.end());
+
+  scoped_ptr<base::DictionaryValue> coped_onc(new base::DictionaryValue());

[stevenjb, 2015/11/05 23:48:25]

s/coped/copied/

[xdai1, 2015/11/06 23:23:02]

Done.

+  coped_onc->Set(onc::toplevel_config::kType,
+                 new base::StringValue(onc::network_type::kWiFi));
+  coped_onc->Set(onc::network_config::WifiProperty(onc::wifi::kSSID),
+                 new base::StringValue(ssid));
+  coped_onc->Set(onc::network_config::WifiProperty(onc::wifi::kSecurity),
+                 new base::StringValue(security));
+
+  std::string onc_spec;
+  base::JSONWriter::Write(*coped_onc.get(), &onc_spec);
+  return onc_spec;
+}
+
 void NetworkScreen::CreateNetworkFromOnc(const std::string& onc_spec) {
   network_state_helper_->CreateNetworkFromOnc(onc_spec);
 }
 
 void NetworkScreen::AddObserver(Observer* observer) {
   if (observer)
     observers_.AddObserver(observer);
 }
 
 void NetworkScreen::RemoveObserver(Observer* observer) {
@@ skipping 150 matching lines @@
   FOR_EACH_OBSERVER(Observer, observers_, OnLanguageListReloaded());
 }
 
 void NetworkScreen::OnSystemTimezoneChanged() {
   std::string current_timezone_id;
   CrosSettings::Get()->GetString(kSystemTimezone, &current_timezone_id);
   GetContextEditor().SetString(kContextKeyTimezone, current_timezone_id);
 }
 
 }  // namespace chromeos