chrome/browser/resources/settings/site_settings/site_list.js - Issue 1428313002: Add a page for showing the details for a given origin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_list.js

Issue 1428313002: Add a page for showing the details for a given origin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_details_permission.js ('k') | chrome/browser/resources/settings/site_settings/site_settings_behavior.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_list.js

diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js

index 613008a45b174e9debbf7b4933dd693a7e82014e..5f0f4a7e098349b8e9a396775fbd78647551e75e 100644

--- a/chrome/browser/resources/settings/site_settings/site_list.js

+++ b/chrome/browser/resources/settings/site_settings/site_list.js

@@ -158,9 +158,9 @@ Polymer({

setUpActionMenu_: function() {

this.showAllowAction_ =

- this.categorySubtype == settings.DefaultValues.BLOCK;

+ this.categorySubtype == settings.PermissionValues.BLOCK;

this.showBlockAction_ =

- this.categorySubtype == settings.DefaultValues.ALLOW &&

+ this.categorySubtype == settings.PermissionValues.ALLOW &&

this.category != settings.ContentSettingsTypes.FULLSCREEN;

@@ -189,7 +189,7 @@ Polymer({

* @private

computeSiteListHeader_: function(siteList, toggleState) {

- if (this.categorySubtype == settings.DefaultValues.ALLOW) {

+ if (this.categorySubtype == settings.PermissionValues.ALLOW) {

return loadTimeData.getStringF(

'titleAndCount',

loadTimeData.getString(

@@ -208,7 +208,7 @@ Polymer({

* @private

isAllowList_: function() {

- return this.categorySubtype == settings.DefaultValues.ALLOW;

+ return this.categorySubtype == settings.PermissionValues.ALLOW;

/**