chrome/browser/resources/settings/site_settings/site_details_permission.html - Issue 1428313002: Add a page for showing the details for a given origin

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_details_permission.html

Issue 1428313002: Add a page for showing the details for a given origin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/site_settings/site_details_permission.css ('K') | « chrome/browser/resources/settings/site_settings/site_details_permission.css ('k') | chrome/browser/resources/settings/site_settings/site_details_permission.js » ('j') | chrome/browser/resources/settings/site_settings/site_details_permission.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/av-icons.htm l">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/communicatio n-icons.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/social-icons .html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">

	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

	8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">

	9 <link rel="import" href="chrome://md-settings/prefs/prefs_behavior.html">

	10 <link rel="import" href="chrome://md-settings/site_settings/site_settings_behavi or.html">

	11

	12 <dom-module id="site-details-permission">

	13 <link rel="import" type="css"

	14 href="chrome://md-settings/settings_page/settings_page.css">

	15 <link rel="import" type="css" href="site_details_permission.css">

	16 <template>

	17 <div id="details" class="horizontal layout top" hidden>
	michaelpg 2015/11/09 18:26:30 import iron-flex-layout import iron-flex-layout Finnur 2015/11/10 16:00:51 Done. Show quoted text On 2015/11/09 18:26:30, michaelpg wrote: > import iron-flex-layout Done.
	18 <div class="left-column">

	19 <iron-icon icon="[[computeIconForContentCategory(category)]]"

	20 item-icon></iron-icon>

	21 </div>

	22 <div class="flex right-column">

	23 <div class="permission-header"

	24 >[[computeTitleForContentCategory(category)]]</div>
	michaelpg 2015/11/09 18:26:30 This hack should no longer be necessary: https:// This hack should no longer be necessary: https://github.com/Polymer/polymer/pull/2489/commits Finnur 2015/11/10 00:36:46 I'm sorry, I don't follow... which hack? The \|tit I'm sorry, I don't follow... which hack? The \|title\| isn't compound and this is used elsewhere, so a utility function makes sense. michaelpg 2015/11/10 00:40:45 No, I meant that putting ">" after the break so th Show quoted text On 2015/11/10 00:36:46, Finnur wrote: > I'm sorry, I don't follow... which hack? > > The \|title\| isn't compound and this is used elsewhere, so a utility function > makes sense. No, I meant that putting ">" after the break so that the [[annotation]] spans the entire tag is no longer necessary, because string interpolation is now supported in Polymer. <div> [[yayWhitespace(hooray)]] </div> Finnur 2015/11/10 16:00:51 Woot! Done. Woot! Done.
	25 <div class="permission-list">

	26 <paper-dropdown-menu>

	27 <paper-menu id="permission" class="dropdown-content">

	28 <paper-item>[[i18n_.allowAction]]</paper-item>

	29 <paper-item>[[i18n_.blockAction]]</paper-item>

	30 </paper-menu>

	31 </paper-dropdown-menu>

	32 </div>

	33 </div>

	34 </div>

	35 </template>

	36 <script src="site_details_permission.js"></script>

	37 </dom-module>

OLD	NEW