chrome/browser/resources/settings/site_settings/site_details.html - Issue 1428313002: Add a page for showing the details for a given origin

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_details.html

Issue 1428313002: Add a page for showing the details for a given origin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/site_settings/site_details.css ('K') | « chrome/browser/resources/settings/site_settings/site_details.css ('k') | chrome/browser/resources/settings/site_settings/site_details.js » ('j') | chrome/browser/resources/settings/site_settings/site_details.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

	4 <link rel="import" href="chrome://md-settings/site_settings/site_details_permiss ion.html">

	5

	6 <dom-module id="site-details">

	7 <link rel="import" type="css"

	8 href="chrome://md-settings/settings_page/settings_page.css">

	9 <link rel="import" type="css" href="site_details.css">

	10 <template>

	11 <div class="origin">{{origin}}</div>
	michaelpg 2015/11/09 18:26:29 nit: we tend to use [[]] instead of {{}} when the nit: we tend to use [[]] instead of {{}} when the binding can only be one-way. There's no effective difference in cases like this. I just think it adds clarity and shows your intention better. Finnur 2015/11/10 16:00:51 Done. Show quoted text On 2015/11/09 18:26:29, michaelpg wrote: > nit: we tend to use [[]] instead of {{}} when the binding can only be one-way. > There's no effective difference in cases like this. I just think it adds clarity > and shows your intention better. Done.
	12 <h2 i18n-content="siteSettingsUsage" id="usage" hidden></h2>

	13 <paper-item id="storage" hidden>

	14 <div class="flex">{{storedData}}</div>
	michaelpg 2015/11/09 18:26:30 import iron-flex-layout (or use a custom class and import iron-flex-layout (or use a custom class and write your own CSS) Finnur 2015/11/10 16:00:51 Done. Show quoted text On 2015/11/09 18:26:30, michaelpg wrote: > import iron-flex-layout (or use a custom class and write your own CSS) Done.
	15 <paper-icon-button icon="delete"

	16 on-tap="onClearStorage_" alt="delete"></paper-icon-button>
	michaelpg 2015/11/09 18:26:30 i18n-values="alt:delete" (and add the string) i18n-values="alt:delete" (and add the string) Finnur 2015/11/10 16:00:51 Done. Show quoted text On 2015/11/09 18:26:30, michaelpg wrote: > i18n-values="alt:delete" (and add the string) Done.
	17 </paper-item>

	18 <h2 i18n-content="siteSettingsPermissions"></h2>

	19 <site-details-permission prefs="{{prefs}}" id="cookies">

	20 </site-details-permission>

	21 <site-details-permission prefs="{{prefs}}" id="javascript">

	22 </site-details-permission>

	23 <site-details-permission prefs="{{prefs}}" id="popups">

	24 </site-details-permission>

	25 <site-details-permission prefs="{{prefs}}" id="geolocation">

	26 </site-details-permission>

	27 <site-details-permission prefs="{{prefs}}" id="notification">

	28 </site-details-permission>

	29 <site-details-permission prefs="{{prefs}}" id="fullscreen">

	30 </site-details-permission>

	31 <site-details-permission prefs="{{prefs}}" id="camera">

	32 </site-details-permission>

	33 <site-details-permission prefs="{{prefs}}" id="mic">

	34 </site-details-permission>

	35 <paper-button

	36 on-tap="onClearAndReset_"

	37 raised i18n-content="siteSettingsClearAndReset"

	38 class="reset-button"></paper-button>

	39 </template>

	40 <script src="site_details.js"></script>

	41 </dom-module>

OLD	NEW