Issue 14283006: Add OWNERS file to tld_cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14283006: Add OWNERS file to tld_cleanup. (Closed)

Created:
7 years, 8 months ago by nyquist

Modified:
7 years, 8 months ago

Reviewers:
Pam (message me for reviews), Peter Kasting, Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, Pam (message me for reviews), Peter Kasting

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add OWNERS file to tld_cleanup. The tld_cleanup command-line program converts an effective-TLD data file to an internal format expected by Chrome. This tool is maintained by pam@ so this adds a directory level OWNERS file. BUG=96086 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196878

Patch Set 1 #

Patch Set 2 : Removing pkasting@ from OWNERS #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	A	net/tools/tld_cleanup/OWNERS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

Usually good to +cc the people you're about to add to OWNERS. LGTM, barring their ...

7 years, 8 months ago (2013-04-26 18:39:49 UTC) #2

nyquist

Submitting after talking to pam@ on chat. pkasting@ decided not to be in the OWNERS ...

7 years, 8 months ago (2013-04-26 18:47:56 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/14283006/3002

7 years, 8 months ago (2013-04-26 18:48:12 UTC) #5

Message was sent while issue was closed.

Change committed as 196878

Expand Messages | Collapse Messages