Fix of password autofilling on hidden passwords forms.

chrome/browser/password_manager/password_manager_browsertest.cc

Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 0f5dfdcf5fae27488ffa73175acdc788047d26ad..295849ca094ab9474c5a8381a664009138ca914c 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -2584,7 +2584,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
 
   std::string get_username =
       "window.domAutomationController.send("
-      "  document.getElementById('username').value);";
+      "  document.getElementById('form_with_hidden_password_username').value);";
   std::string actual_username;
   ASSERT_TRUE(content::ExecuteScriptAndExtractString(
       RenderViewHost(), get_username, &actual_username));
@@ -2592,7 +2592,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
 
   std::string get_password =
       "window.domAutomationController.send("
-      "  document.getElementById('password').value);";
+      "  document.getElementById('form_with_hidden_password_password').value);";
   std::string actual_password;
   ASSERT_TRUE(content::ExecuteScriptAndExtractString(
       RenderViewHost(), get_password, &actual_password));
@@ -2646,4 +2646,52 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
   EXPECT_EQ("mypassword", actual_password);
 }
 
+// Test whether the password form which is loaded as hidden is autofilled

[vabr (Chromium), 2015/11/05 15:20:24]

Please mention the difference against
AutofillSuggetionsForProblematicPasswordForm in the comment, and move this test
just after AutofillSuggetionsForProblematicPasswordForm.

[dvadym, 2015/11/05 16:18:25]

Done.

+// correctly. This shows very often situation when in order to sign-in the user

[vabr (Chromium), 2015/11/05 15:20:24]

nit: shows -> happens; situation -> in situations

[dvadym, 2015/11/05 16:18:26]

Done.

+// clicks sign-in and a hidden passsword form becomes visible.

[vabr (Chromium), 2015/11/05 15:20:24]

nit: "sign-in" -> "a sign-in button"

[dvadym, 2015/11/05 16:18:25]

Done.

+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
+                       AutofillSuggetionsHiddenPasswordForm) {
+  // At first let us save credentials to the PasswordManager.
+  scoped_refptr<password_manager::PasswordStore> password_store =
+      PasswordStoreFactory::GetForProfile(browser()->profile(),
+                                          ServiceAccessType::IMPLICIT_ACCESS);
+  autofill::PasswordForm login_form;
+  login_form.signon_realm = embedded_test_server()->base_url().spec();
+  login_form.action = embedded_test_server()->GetURL("/password/done.html");
+  login_form.username_value = base::ASCIIToUTF16("myusername");
+  login_form.password_value = base::ASCIIToUTF16("mypassword");
+  password_store->AddLogin(login_form);
+
+  // Logins are added asynchronously to the password store. Spin the message
+  // loop to make sure the |password_store| had a chance to store the
+  // |login_form|.
+  base::RunLoop run_loop;
+  run_loop.RunUntilIdle();
+
+  // Now, navigate to the password form having ambiguous Ids for username and

[vabr (Chromium), 2015/11/05 15:20:24]

Are the IDs ambiguous? I thought there were hidden_password_form_username and
hidden_password_form_password.

[dvadym, 2015/11/05 16:18:25]

Thanks, no, it was copy paste of copy paste :). I've fixed also a comment in
another test

+  // password fields and verify whether username and password is autofilled.
+  NavigateToFile("/password/password_form.html");
+
+  // Let the user interact with the page, so that DOM gets modification events,
+  // needed for autofilling fields.
+  content::SimulateMouseClickAt(
+      WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+
+  std::string get_username =
+      "window.domAutomationController.send("
+      "  document.getElementById('hidden_password_form_username').value);";
+  std::string actual_username;
+  ASSERT_TRUE(content::ExecuteScriptAndExtractString(
+      RenderViewHost(), get_username, &actual_username));
+  EXPECT_EQ("myusername", actual_username);
+
+  std::string get_password =
+      "window.domAutomationController.send("
+      "  document.getElementById('hidden_password_form_password').value);";
+  std::string actual_password;
+  ASSERT_TRUE(content::ExecuteScriptAndExtractString(
+      RenderViewHost(), get_password, &actual_password));
+  EXPECT_EQ("mypassword", actual_password);
+}
+
 }  // namespace password_manager