Fix of password autofilling on hidden passwords forms.

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/i18n/case_conversion.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 167 matching lines @@
     if (!control_element.hasHTMLTagName("input"))
       continue;
 
     // Only fill saved passwords into password fields and usernames into text
     // fields.
     const blink::WebInputElement input_element =
         control_element.toConst<blink::WebInputElement>();
     if (input_element.isPasswordField() != is_password_field)
       continue;
 
-    // Avoid autofilling invisible password fields.
-    if (input_element.isPasswordField() &&
-        !form_util::IsWebNodeVisible(input_element)) {
-      continue;
-    }
-
     // For change password form with ambiguous or empty names keep only the
     // first password field having |autocomplete='current-password'| attribute
     // set. Also make sure we avoid keeping password fields having
     // |autocomplete='new-password'| attribute set.
     if (ambiguous_and_multiple_password_fields_with_autocomplete &&
         !HasAutocompleteAttributeValue(input_element, "current-password")) {
       continue;
     }
 
     // Check for a non-unique match.
     if (found_input) {
       // For change password form keep only the first password field entry.
-      if (does_password_field_has_ambigous_or_empty_name)
+      if (does_password_field_has_ambigous_or_empty_name) {
+        if (!form_util::IsWebNodeVisible((*result)[field_name])) {

[vabr (Chromium), 2015/11/05 15:20:25]

Is this code path tested? The added test does not seem to involve ambiguous or
empty field names.

[dvadym, 2015/11/05 16:18:26]

It's tested in previously added test
AutofillSuggetionsForProblematicAmbiguousPasswordForm line 2604 in
password_manager_browsertest.cc, namely there is password form with 2 password
fields without id/name, the first of them is hidden.

[vabr (Chromium), 2015/11/05 16:29:46]

Acknowledged.

+          // If a previously chosen field was invisible then take the current
+          // one.
+          (*result)[field_name] = input_element;
+        }
         continue;
+      }
 
       found_input = false;
       break;
     }
 
     (*result)[field_name] = input_element;
     found_input = true;
   }
 
   // A required element was not found. This is not the right form.
@@ skipping 1303 matching lines @@
 void PasswordAutofillAgent::LegacyPasswordAutofillAgent::OnDestruct() {
   // No op. Do not delete |this|.
 }
 
 void PasswordAutofillAgent::LegacyPasswordAutofillAgent::
     DidStartProvisionalLoad(blink::WebLocalFrame* navigated_frame) {
   agent_->LegacyDidStartProvisionalLoad(navigated_frame);
 }
 
 }  // namespace autofill