Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1428263003: Remove fallback tick software draw. (Closed)

Created:
5 years, 1 month ago by Tobias Sargeant
Modified:
5 years, 1 month ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fallback tick software draw. The fallback software draw was needed to allow the scheduler to advance in cases where the WebView is detached or offscreen. Because it is now possible for the pending tree to activate without a draw, the fallback tick is no longer needed in order for VisualStateListener callbacks to fire. BUG=431166 Committed: https://crrev.com/9addff46d3bc49f8d04e43eeb3f55e01a4982a00 Cr-Commit-Position: refs/heads/master@{#358156}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -159 lines) Patch
M android_webview/android_webview_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M android_webview/browser/browser_view_renderer.h View 1 2 3 chunks +0 lines, -15 lines 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 1 2 7 chunks +6 lines, -84 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java View 1 2 4 chunks +45 lines, -60 lines 0 comments Download
A android_webview/test/shell/assets/visual_state_waits_for_js_detached_test.html View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Tobias Sargeant
5 years, 1 month ago (2015-11-05 17:31:18 UTC) #3
boliu
https://codereview.chromium.org/1428263003/diff/40001/android_webview/browser/browser_view_renderer.cc File android_webview/browser/browser_view_renderer.cc (right): https://codereview.chromium.org/1428263003/diff/40001/android_webview/browser/browser_view_renderer.cc#newcode228 android_webview/browser/browser_view_renderer.cc:228: bool BrowserViewRenderer::CompositeHw() { can merge this back into OnHardwareDraw ...
5 years, 1 month ago (2015-11-05 17:48:03 UTC) #4
Tobias Sargeant
https://codereview.chromium.org/1428263003/diff/40001/android_webview/browser/browser_view_renderer.cc File android_webview/browser/browser_view_renderer.cc (right): https://codereview.chromium.org/1428263003/diff/40001/android_webview/browser/browser_view_renderer.cc#newcode228 android_webview/browser/browser_view_renderer.cc:228: bool BrowserViewRenderer::CompositeHw() { On 2015/11/05 17:48:03, boliu wrote: > ...
5 years, 1 month ago (2015-11-05 22:30:16 UTC) #7
boliu
lgtm
5 years, 1 month ago (2015-11-05 22:31:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428263003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428263003/100001
5 years, 1 month ago (2015-11-05 22:35:12 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 1 month ago (2015-11-05 22:51:44 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9addff46d3bc49f8d04e43eeb3f55e01a4982a00 Cr-Commit-Position: refs/heads/master@{#358156}
5 years, 1 month ago (2015-11-05 22:52:44 UTC) #12
Tobias Sargeant
5 years, 1 month ago (2015-11-24 10:14:43 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:100001) has been created in
https://codereview.chromium.org/1474653002/ by tobiasjs@chromium.org.

The reason for reverting is: Causes scheduler to stop activating after clearView
is called. PrepareTiles is required to advance the scheduler, so draws are
currently needed.

crbug.com/558743.

Powered by Google App Engine
This is Rietveld 408576698