[turbofan] Add support for relevant ES6 type conversion intrinsics.

[turbofan] Add support for relevant ES6 type conversion intrinsics.

TurboFan didn't fully support the relevant ES6 type conversion
intrinsics like %_ToNumber, %_ToLength, %_ToName, %_ToString and
%_ToInteger until now, we always went to the runtime instead.  These
intrinsics are now well supported in TurboFan, and we are even able to
generate quite decent code in some cases.

R=jarin@chromium.org

Committed: https://crrev.com/8d780560bdf9fba46dfa2ac9e508b9c131cbad69
Cr-Commit-Position: refs/heads/master@{#31820}

[Benedikt Meurer, 2015-11-05 08:06:34]

Hey Jaro,

This CL adds support for the type conversion intrinsics that we are currently
using to implement ES6 in our native .js files.
Please take a look.

Thanks,
Benedikt

[Benedikt Meurer, 2015-11-05 09:09:23]

Patchset #1 (id:1) has been deleted

[Benedikt Meurer, 2015-11-05 09:09:30]

Patchset #1 (id:20001) has been deleted

[Michael Starzinger, 2015-11-05 09:10:45]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-11-05 09:10:46]

LGTM (rubber-stamped "heap", didn't look at the rest).

[Jarin, 2015-11-05 09:25:30]

lgtm with nits.

https://codereview.chromium.org/1428243003/diff/40001/src/compiler/js-intrins...
File src/compiler/js-intrinsic-lowering.cc (right):

https://codereview.chromium.org/1428243003/diff/40001/src/compiler/js-intrins...
src/compiler/js-intrinsic-lowering.cc:583: NodeProperties::SetType(value,
value_type);
Ouch. I am wondering whether we will want to have some kind of Min/Max operators
that would eliminate the need for type-smashing.

https://codereview.chromium.org/1428243003/diff/40001/src/type-cache.h
File src/type-cache.h (right):

https://codereview.chromium.org/1428243003/diff/40001/src/type-cache.h#newcode50
src/type-cache.h:50: Type* const kIntegerish = Type::Union(kInteger,
Type::MinusZero(), zone());
I think we need better names for this. How about kIntegerOrMinusZero,
kIntegerOrMinusZeroOrNaN or some such?

Especially because this is inconsistent with the Zeroish above, where the -ish
meand -or-minus-zero-or-nan. (So by your new scheme it would be WeakZero?)

[Benedikt Meurer, 2015-11-05 09:30:05]

https://codereview.chromium.org/1428243003/diff/40001/src/type-cache.h
File src/type-cache.h (right):

https://codereview.chromium.org/1428243003/diff/40001/src/type-cache.h#newcode50
src/type-cache.h:50: Type* const kIntegerish = Type::Union(kInteger,
Type::MinusZero(), zone());
On 2015/11/05 09:25:29, Jarin wrote:
> I think we need better names for this. How about kIntegerOrMinusZero,
> kIntegerOrMinusZeroOrNaN or some such?
> 
> Especially because this is inconsistent with the Zeroish above, where the -ish
> meand -or-minus-zero-or-nan. (So by your new scheme it would be WeakZero?)

Done.

[Benedikt Meurer, 2015-11-05 09:30:09]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-11-05 09:30:09]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1428243003/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2015-11-05 09:30:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428243003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428243003/60001

[commit-bot: I haz the power, 2015-11-05 09:51:01]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-11-05 09:51:41]

Patchset 2 (id:??) landed as
https://crrev.com/8d780560bdf9fba46dfa2ac9e508b9c131cbad69
Cr-Commit-Position: refs/heads/master@{#31820}