Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5866)

Unified Diff: chrome/browser/ui/browser_navigator_browsertest_chromeos.cc

Issue 1428213004: This CL replaces std::string user_id in ash/* with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after review. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
diff --git a/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc b/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
index de7baecf63e259b7d6e5444f5a2a20c11075e793..e125acbe84a0275649f8ca37d2263a56670ed7a9 100644
--- a/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
+++ b/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_switches.h"
#include "chromeos/chromeos_switches.h"
+#include "components/signin/core/account_id/account_id.h"
#include "content/public/browser/web_contents.h"
namespace {
@@ -73,9 +74,10 @@ IN_PROC_BROWSER_TEST_F(BrowserGuestSessionNavigatorTest,
// Test 1: Test that a browser created from a visiting browser will be on the
// same visiting desktop.
{
- const std::string desktop_user_id = "desktop_user_id@fake.com";
+ const AccountId desktop_account_id(
+ AccountId::FromUserEmail("desktop_user_id@fake.com"));
TestMultiUserWindowManager* manager =
- new TestMultiUserWindowManager(browser(), desktop_user_id);
+ new TestMultiUserWindowManager(browser(), desktop_account_id);
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
@@ -92,14 +94,14 @@ IN_PROC_BROWSER_TEST_F(BrowserGuestSessionNavigatorTest,
aura::Window* created_window = manager->created_window();
ASSERT_TRUE(created_window);
- EXPECT_TRUE(manager->IsWindowOnDesktopOfUser(created_window,
- desktop_user_id));
+ EXPECT_TRUE(
+ manager->IsWindowOnDesktopOfUser(created_window, desktop_account_id));
}
// Test 2: Test that a window which is not visiting does not cause an owner
// assignment of a newly created browser.
{
- std::string browser_owner =
- multi_user_util::GetUserIDFromProfile(browser()->profile());
+ const AccountId browser_owner =
+ multi_user_util::GetAccountIdFromProfile(browser()->profile());
TestMultiUserWindowManager* manager =
new TestMultiUserWindowManager(browser(), browser_owner);
« no previous file with comments | « chrome/browser/ui/browser_navigator.cc ('k') | chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698