chrome/browser/signin/signin_error_notifier_ash.cc - Issue 1428213004: This CL replaces std::string user_id in ash/* with AccountId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_error_notifier_ash.cc

Issue 1428213004: This CL replaces std::string user_id in ash/* with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update after review. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/system/tray/system_tray_delegate.cc ('K') | « chrome/browser/notifications/profile_notification.cc ('k') | chrome/browser/sync/sync_error_notifier_ash.cc » ('j') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_error_notifier_ash.cc

diff --git a/chrome/browser/signin/signin_error_notifier_ash.cc b/chrome/browser/signin/signin_error_notifier_ash.cc

index 60e5f49741a20f3cbe2b21c55eae096dc7c79b4b..ef864400a50fc81394dc30ea7987f6e1e765987a 100644

--- a/chrome/browser/signin/signin_error_notifier_ash.cc

+++ b/chrome/browser/signin/signin_error_notifier_ash.cc

@@ -26,6 +26,7 @@

#include "chrome/common/url_constants.h"

#include "chrome/grit/chromium_strings.h"

#include "chrome/grit/generated_resources.h"

+#include "components/signin/core/account_id/account_id.h"

#include "grit/theme_resources.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/resource/resource_bundle.h"

@@ -174,7 +175,8 @@ void SigninErrorNotifier::OnErrorChanged() {

kProfileSigninNotificationId);

// Set |profile_id| for multi-user notification blocker.

- notifier_id.profile_id = multi_user_util::GetUserIDFromProfile(profile_);

+ notifier_id.profile_id =

+ multi_user_util::GetAccountIdFromProfile(profile_).GetUserEmail();

Notification notification(

message_center::NOTIFICATION_TYPE_SIMPLE,