Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1428213003: Preload the media foundation, h.264 decoder and the dxva2.dll before the gpu sandbox is initialized. (Closed)

Created:
5 years, 1 month ago by ananta
Modified:
5 years, 1 month ago
Reviewers:
DaleCurtis, jbauman
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preload the media foundation, h.264 decoder and the dxva2.dll before the gpu sandbox is initialized. It looks like in some configurations in the wild loading these dlls in the sandbox causes crashes. BUG=551077 Committed: https://crrev.com/b03aa179444234dd526929ba1c6eae23802d57de Cr-Commit-Position: refs/heads/master@{#358217}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Total comments: 2

Patch Set 3 : Fix defined macros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -17 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 2 4 chunks +28 lines, -17 lines 0 comments Download
M content/gpu/gpu_main.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (3 generated)
ananta
5 years, 1 month ago (2015-11-04 22:50:48 UTC) #2
jbauman
lgtm with one nit. https://codereview.chromium.org/1428213003/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc File content/common/gpu/media/dxva_video_decode_accelerator.cc (right): https://codereview.chromium.org/1428213003/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc#newcode658 content/common/gpu/media/dxva_video_decode_accelerator.cc:658: if ((dxgi_manager_dll = ::GetModuleHandle(L"MFPlat.dll")) == ...
5 years, 1 month ago (2015-11-04 23:02:02 UTC) #3
ananta
https://codereview.chromium.org/1428213003/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc File content/common/gpu/media/dxva_video_decode_accelerator.cc (right): https://codereview.chromium.org/1428213003/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc#newcode658 content/common/gpu/media/dxva_video_decode_accelerator.cc:658: if ((dxgi_manager_dll = ::GetModuleHandle(L"MFPlat.dll")) == NULL) { On 2015/11/04 ...
5 years, 1 month ago (2015-11-04 23:15:08 UTC) #4
DaleCurtis
https://codereview.chromium.org/1428213003/diff/20001/content/common/gpu/media/dxva_video_decode_accelerator.cc File content/common/gpu/media/dxva_video_decode_accelerator.cc (right): https://codereview.chromium.org/1428213003/diff/20001/content/common/gpu/media/dxva_video_decode_accelerator.cc#newcode1043 content/common/gpu/media/dxva_video_decode_accelerator.cc:1043: #if defined ENABLE_DX11_FOR_WIN7 #if defined(ENABLED_DX11_FOR_WIN7) ... but where is ...
5 years, 1 month ago (2015-11-05 01:07:59 UTC) #5
ananta
https://codereview.chromium.org/1428213003/diff/20001/content/common/gpu/media/dxva_video_decode_accelerator.cc File content/common/gpu/media/dxva_video_decode_accelerator.cc (right): https://codereview.chromium.org/1428213003/diff/20001/content/common/gpu/media/dxva_video_decode_accelerator.cc#newcode1043 content/common/gpu/media/dxva_video_decode_accelerator.cc:1043: #if defined ENABLE_DX11_FOR_WIN7 On 2015/11/05 01:07:58, DaleCurtis wrote: > ...
5 years, 1 month ago (2015-11-05 19:13:02 UTC) #6
DaleCurtis
Okay, can you convert all of these to defined(__) syntax? That's what we use elsewhere.
5 years, 1 month ago (2015-11-05 20:20:17 UTC) #7
ananta
On 2015/11/05 20:20:17, DaleCurtis wrote: > Okay, can you convert all of these to defined(__) ...
5 years, 1 month ago (2015-11-05 20:33:55 UTC) #8
DaleCurtis
lgtm
5 years, 1 month ago (2015-11-05 22:45:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428213003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428213003/40001
5 years, 1 month ago (2015-11-05 23:11:21 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-06 01:21:39 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 01:22:35 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b03aa179444234dd526929ba1c6eae23802d57de
Cr-Commit-Position: refs/heads/master@{#358217}

Powered by Google App Engine
This is Rietveld 408576698