Preload the media foundation, h.264 decoder and the dxva2.dll before the gpu sandbox is initialized.

Preload the media foundation, h.264 decoder and the dxva2.dll before the gpu sandbox is initialized.

It looks like in some configurations in the wild loading these dlls in the sandbox causes crashes.

BUG=551077
Committed: https://crrev.com/b03aa179444234dd526929ba1c6eae23802d57de
Cr-Commit-Position: refs/heads/master@{#358217}

[ananta, 2015-11-04 22:50:48]

ananta@chromium.org changed reviewers:
+ dalecurtis@chromium.org, jbauman@chromium.org

[jbauman, 2015-11-04 23:02:02]

lgtm with one nit.

https://codereview.chromium.org/1428213003/diff/1/content/common/gpu/media/dx...
File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1428213003/diff/1/content/common/gpu/media/dx...
content/common/gpu/media/dxva_video_decode_accelerator.cc:658: if
((dxgi_manager_dll = ::GetModuleHandle(L"MFPlat.dll")) == NULL) {
Remove this if - do 'HMODULE dxgi_manager_dll =
::GetModuleHandle(L"MFPlat.dll");' above and just do the RETURN_ON_FAILURE
afterwards.

[ananta, 2015-11-04 23:15:08]

https://codereview.chromium.org/1428213003/diff/1/content/common/gpu/media/dx...
File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1428213003/diff/1/content/common/gpu/media/dx...
content/common/gpu/media/dxva_video_decode_accelerator.cc:658: if
((dxgi_manager_dll = ::GetModuleHandle(L"MFPlat.dll")) == NULL) {
On 2015/11/04 23:02:02, jbauman wrote:
> Remove this if - do 'HMODULE dxgi_manager_dll =
> ::GetModuleHandle(L"MFPlat.dll");' above and just do the RETURN_ON_FAILURE
> afterwards.

Done.

[DaleCurtis, 2015-11-05 01:07:59]

https://codereview.chromium.org/1428213003/diff/20001/content/common/gpu/medi...
File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1428213003/diff/20001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.cc:1043: #if defined
ENABLE_DX11_FOR_WIN7
#if defined(ENABLED_DX11_FOR_WIN7)

... but where is this defined now?

[ananta, 2015-11-05 19:13:02]

https://codereview.chromium.org/1428213003/diff/20001/content/common/gpu/medi...
File content/common/gpu/media/dxva_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1428213003/diff/20001/content/common/gpu/medi...
content/common/gpu/media/dxva_video_decode_accelerator.cc:1043: #if defined
ENABLE_DX11_FOR_WIN7
On 2015/11/05 01:07:58, DaleCurtis wrote:
> #if defined(ENABLED_DX11_FOR_WIN7)
> 
> ... but where is this defined now?

It is not defined. As decode using DX11 on Windows 7 does not work due to lack
of a format converter.

[DaleCurtis, 2015-11-05 20:20:17]

Okay, can you convert all of these to defined(__) syntax? That's what we use
elsewhere.

[ananta, 2015-11-05 20:33:55]

On 2015/11/05 20:20:17, DaleCurtis wrote:
> Okay, can you convert all of these to defined(__) syntax? That's what we use
> elsewhere.

done.

[DaleCurtis, 2015-11-05 22:45:04]

lgtm

[ananta, 2015-11-05 23:09:45]

The CQ bit was checked by ananta@chromium.org

[ananta, 2015-11-05 23:09:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/1428213003/#ps40001
(title: "Fix defined macros")

[commit-bot: I haz the power, 2015-11-05 23:11:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428213003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428213003/40001

[commit-bot: I haz the power, 2015-11-06 01:21:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-06 01:22:35]

Patchset 3 (id:??) landed as
https://crrev.com/b03aa179444234dd526929ba1c6eae23802d57de
Cr-Commit-Position: refs/heads/master@{#358217}