Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: src/js/regexp.js

Issue 1428203003: Use in-object fields instead of private symbols for regexp slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: using IS_REGEXP check Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/js/regexp.js
diff --git a/src/js/regexp.js b/src/js/regexp.js
index 79e38ed272cf64e770c1656ecc5cfdf18398b4df..c6a742e34ea4a2cadf205117c0d7659aa6d38c3e 100644
--- a/src/js/regexp.js
+++ b/src/js/regexp.js
@@ -14,8 +14,6 @@ var GlobalObject = global.Object;
var GlobalRegExp = global.RegExp;
var InternalPackedArray = utils.InternalPackedArray;
var MakeTypeError;
-var regExpFlagsSymbol = utils.ImportNow("regexp_flags_symbol");
-var regExpSourceSymbol = utils.ImportNow("regexp_source_symbol");
utils.ImportFromExperimental(function(from) {
FLAG_harmony_tolength = from.FLAG_harmony_tolength;
@@ -334,14 +332,10 @@ function RegExpMakeCaptureGetter(n) {
// ES6 21.2.5.4, 21.2.5.5, 21.2.5.7, 21.2.5.12, 21.2.5.15.
function GetRegExpFlagGetter(name, mask) {
var getter = function() {
- if (!IS_SPEC_OBJECT(this)) {
+ if (!IS_REGEXP(this)) {
throw MakeTypeError(kRegExpNonObject, name, TO_STRING(this));
}
- var flags = this[regExpFlagsSymbol];
- if (IS_UNDEFINED(flags)) {
- throw MakeTypeError(kRegExpNonRegExp, TO_STRING(this));
- }
- return !!(flags & mask);
+ return !!(%_RegExpFlags(this) & mask);
};
%FunctionSetName(getter, name);
%SetNativeFlag(getter);
@@ -351,15 +345,11 @@ function GetRegExpFlagGetter(name, mask) {
// ES6 21.2.5.10.
function RegExpGetSource() {
- if (!IS_SPEC_OBJECT(this)) {
+ if (!IS_REGEXP(this)) {
throw MakeTypeError(kRegExpNonObject, "RegExp.prototype.source",
TO_STRING(this));
}
- var source = this[regExpSourceSymbol];
- if (IS_UNDEFINED(source)) {
- throw MakeTypeError(kRegExpNonRegExp, TO_STRING(this));
- }
- return source;
+ return %RegExpSource(this);
}
%SetNativeFlag(RegExpGetSource);
« src/crankshaft/hydrogen-instructions.h ('K') | « src/js/macros.py ('k') | src/js/string.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698