src/crankshaft/hydrogen.h - Issue 1428203003: Use in-object fields instead of private symbols for regexp slots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.h

Issue 1428203003: Use in-object fields instead of private symbols for regexp slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: using IS_REGEXP check Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/hydrogen.h

diff --git a/src/crankshaft/hydrogen.h b/src/crankshaft/hydrogen.h

index b141c99fc060df2963c11c6ba8fbd8e0c6037863..e34a7c9b0d82eb5f669416163650383f16b6ad0a 100644

--- a/src/crankshaft/hydrogen.h

+++ b/src/crankshaft/hydrogen.h

@@ -2235,6 +2235,7 @@ class HOptimizedGraphBuilder : public HGraphBuilder, public AstVisitor {

F(SubString) \

F(RegExpExec) \

F(RegExpConstructResult) \

+ F(RegExpFlags) \

Benedikt Meurer 2015/11/04 14:02:40 What about RegExpSource?

F(NumberToString) \

F(DebugIsActive) \

F(Likely) \

« no previous file with comments | « src/bootstrapper.cc ('k') | src/crankshaft/hydrogen.cc » ('j') | src/crankshaft/hydrogen-instructions.h » ('J')