Use in-object fields instead of private symbols for regexp slots.

Use in-object fields instead of private symbols for regexp slots.

R=bmeurer@chromium.org

Committed: https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e
Cr-Commit-Position: refs/heads/master@{#31791}

Committed: https://crrev.com/bf5c9af92ac0a5b7f020ac968d3d42ed06aa6144
Cr-Commit-Position: refs/heads/master@{#31805}

Committed: https://crrev.com/8f74173812423224113f8b722bbda9760492c860
Cr-Commit-Position: refs/heads/master@{#31838}

[Yang, 2015-11-04 14:01:00]

On 2015/11/04 13:52:17, Yang wrote:

Changed to use IS_REGEXP as discussed offline.

[Benedikt Meurer, 2015-11-04 14:02:40]

https://codereview.chromium.org/1428203003/diff/20001/src/crankshaft/hydrogen...
File src/crankshaft/hydrogen-instructions.h (right):

https://codereview.chromium.org/1428203003/diff/20001/src/crankshaft/hydrogen...
src/crankshaft/hydrogen-instructions.h:2886: IS_JS_REGEXP,
Undo these changes.

https://codereview.chromium.org/1428203003/diff/20001/src/crankshaft/hydrogen.h
File src/crankshaft/hydrogen.h (right):

https://codereview.chromium.org/1428203003/diff/20001/src/crankshaft/hydrogen...
src/crankshaft/hydrogen.h:2238: F(RegExpFlags)                       \
What about RegExpSource?

[Yang, 2015-11-04 14:09:00]

On 2015/11/04 14:02:40, Benedikt Meurer wrote:
>
https://codereview.chromium.org/1428203003/diff/20001/src/crankshaft/hydrogen...
> File src/crankshaft/hydrogen-instructions.h (right):
> 
>
https://codereview.chromium.org/1428203003/diff/20001/src/crankshaft/hydrogen...
> src/crankshaft/hydrogen-instructions.h:2886: IS_JS_REGEXP,
> Undo these changes.
> 
>
https://codereview.chromium.org/1428203003/diff/20001/src/crankshaft/hydrogen.h
> File src/crankshaft/hydrogen.h (right):
> 
>
https://codereview.chromium.org/1428203003/diff/20001/src/crankshaft/hydrogen...
> src/crankshaft/hydrogen.h:2238: F(RegExpFlags)                       \
> What about RegExpSource?

Addressed comments.

I had the impression that RegExpSource is not as hot, but it turned out that
inlining it actually helps.

[Benedikt Meurer, 2015-11-04 14:18:15]

Thanks. LGTM

[Yang, 2015-11-04 14:24:29]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-11-04 14:24:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428203003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428203003/60001

[commit-bot: I haz the power, 2015-11-04 14:45:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-04 14:45:46]

Patchset 4 (id:??) landed as
https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e
Cr-Commit-Position: refs/heads/master@{#31791}

[Michael Hablich, 2015-11-04 18:32:17]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1421593009/ by hablich@chromium.org.

The reason for reverting is: A clean revert of
https://codereview.chromium.org/1419823010/ was not possible because of this CL.
Thus, I am also reverting this CL.


.

[Yang, 2015-11-04 19:25:05]

Description was changed from

==========
Use in-object fields instead of private symbols for regexp slots.

R=bmeurer@chromium.org

Committed: https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e
Cr-Commit-Position: refs/heads/master@{#31791}
==========

to

==========
Use in-object fields instead of private symbols for regexp slots.

R=bmeurer@chromium.org

Committed: https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e
Cr-Commit-Position: refs/heads/master@{#31791}
==========

[Yang, 2015-11-04 20:42:53]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-11-04 20:43:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428203003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428203003/60001

[commit-bot: I haz the power, 2015-11-04 20:44:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-04 20:45:02]

Patchset 4 (id:??) landed as
https://crrev.com/bf5c9af92ac0a5b7f020ac968d3d42ed06aa6144
Cr-Commit-Position: refs/heads/master@{#31805}

[Yang, 2015-11-05 09:07:12]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1432453005/ by yangguo@chromium.org.

The reason for reverting is: browser_tests failure with
--gtest_filter=ExternallyConnectableMessagingTest.EnablingAndDisabling.

[Yang, 2015-11-05 18:36:46]

Description was changed from

==========
Use in-object fields instead of private symbols for regexp slots.

R=bmeurer@chromium.org

Committed: https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e
Cr-Commit-Position: refs/heads/master@{#31791}

Committed: https://crrev.com/bf5c9af92ac0a5b7f020ac968d3d42ed06aa6144
Cr-Commit-Position: refs/heads/master@{#31805}
==========

to

==========
Use in-object fields instead of private symbols for regexp slots.

R=bmeurer@chromium.org

Committed: https://crrev.com/5a1e42c039ac3379ebe1e7e34fb8163e1ec1493e
Cr-Commit-Position: refs/heads/master@{#31791}

Committed: https://crrev.com/bf5c9af92ac0a5b7f020ac968d3d42ed06aa6144
Cr-Commit-Position: refs/heads/master@{#31805}
==========

[Yang, 2015-11-05 18:50:48]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-11-05 18:50:49]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1428203003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-11-05 18:51:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428203003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428203003/80001

[commit-bot: I haz the power, 2015-11-05 19:10:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-05 19:10:49]

Patchset 5 (id:??) landed as
https://crrev.com/8f74173812423224113f8b722bbda9760492c860
Cr-Commit-Position: refs/heads/master@{#31838}