Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 14282002: Added support for displaying the select folder picker in Chrome ASH on Windows 8. (Closed)

Created:
7 years, 8 months ago by ananta
Modified:
7 years, 8 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Added support for displaying the select folder picker in Chrome ASH on Windows 8. The current behavior is that the select folder picker displays in desktop mode even when when performed in ASH. Fixes are as below:- 1. In the Chrome browser added plumbing in the SelectFileDialogImpl class to forward this operation of to the metro viewer process via the newly added function HandedSelectFolder which lives in the aura namespace in the remote_window_host_win.cc file. 2. In the metro viewer code added a new class FolderPickerSession which provides the functionality for displaying the metro select folder picker and returning the results from the same. 3. The following IPC messages provide the necessary functionality to funnel the request and the result between the browser and the metro viewer process. MetroViewerHostMsg_DisplaySelectFolder MetroViewerHostMsg_SelectFolderDone I also added code to save away the metro root window in the RemoteRootWindowHostWin class when we receive the MetroViewerHostMsg_SetTargetSurface IPC from the viewer process. We return this window in the RemoteRootWindowHostWin::GetAcceleratedWidget function. This change although not needed for this CL seems correct. BUG=230087 R=cpu,sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195224

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -35 lines) Patch
M ui/aura/remote_root_window_host_win.h View 1 2 3 5 chunks +15 lines, -4 lines 0 comments Download
M ui/aura/remote_root_window_host_win.cc View 1 2 3 7 chunks +40 lines, -9 lines 0 comments Download
M ui/metro_viewer/metro_viewer_messages.h View 1 2 3 3 chunks +14 lines, -7 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.h View 1 2 3 5 chunks +13 lines, -1 line 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 1 2 3 7 chunks +46 lines, -13 lines 0 comments Download
M win8/metro_driver/file_picker_ash.h View 1 chunk +18 lines, -0 lines 0 comments Download
M win8/metro_driver/file_picker_ash.cc View 1 2 3 2 chunks +70 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
ananta
7 years, 8 months ago (2013-04-16 01:39:39 UTC) #1
cpu_(ooo_6.6-7.5)
can we remove the metro_window_ thing from this CL? Lets make a different CL with ...
7 years, 8 months ago (2013-04-16 22:24:14 UTC) #2
cpu_(ooo_6.6-7.5)
When the user switches away from metro, we need to cancel any folder picking, is ...
7 years, 8 months ago (2013-04-16 22:25:20 UTC) #3
ananta
On 2013/04/16 22:25:20, cpu wrote: > When the user switches away from metro, we need ...
7 years, 8 months ago (2013-04-17 01:05:57 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
7 years, 8 months ago (2013-04-17 21:46:59 UTC) #5
ananta
Adding Ben for ui OWNERS lgtm
7 years, 8 months ago (2013-04-17 22:05:32 UTC) #6
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-18 18:20:53 UTC) #7
palmer
https://codereview.chromium.org/14282002/diff/15001/ui/aura/remote_root_window_host_win.cc File ui/aura/remote_root_window_host_win.cc (right): https://codereview.chromium.org/14282002/diff/15001/ui/aura/remote_root_window_host_win.cc#newcode170 ui/aura/remote_root_window_host_win.cc:170: // Can only have have one of these operations ...
7 years, 8 months ago (2013-04-18 22:58:07 UTC) #8
ananta
https://codereview.chromium.org/14282002/diff/15001/ui/aura/remote_root_window_host_win.cc File ui/aura/remote_root_window_host_win.cc (right): https://codereview.chromium.org/14282002/diff/15001/ui/aura/remote_root_window_host_win.cc#newcode170 ui/aura/remote_root_window_host_win.cc:170: // Can only have have one of these operations ...
7 years, 8 months ago (2013-04-19 00:23:24 UTC) #9
palmer
IPC security LGTM. Thanks!
7 years, 8 months ago (2013-04-19 01:10:28 UTC) #10
ananta
7 years, 8 months ago (2013-04-19 17:44:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 manually as r195224 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698