Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1428153003: avx and avx2 detection (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

avx and avx2 detection This doesn't do anything yet beyond print out a message in Debug mode, but it's a start. Those messages should match the -SSE4-, -AVX-, or -AVX2- in the Test-...-Debug-Trybots below. The Release ones are just running by accident. So far they look right to me. BUG=skia: Committed: https://skia.googlesource.com/skia/+/844a0b425741f07cb233332405143931586bbb7d

Patch Set 1 #

Patch Set 2 : avx2 detection #

Patch Set 3 : tidy #

Patch Set 4 : __cpuid_count #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M src/core/SkOpts.cpp View 1 2 3 3 chunks +31 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
mtklein
5 years, 1 month ago (2015-11-06 20:54:12 UTC) #4
msarett
I trust this if the test bots seem to be doing what we expect. I ...
5 years, 1 month ago (2015-11-06 21:57:42 UTC) #6
mtklein
On 2015/11/06 at 21:57:42, msarett wrote: > I trust this if the test bots seem ...
5 years, 1 month ago (2015-11-06 22:26:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428153003/40001
5 years, 1 month ago (2015-11-06 22:26:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/6468)
5 years, 1 month ago (2015-11-06 22:27:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428153003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428153003/60001
5 years, 1 month ago (2015-11-07 03:37:05 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 03:48:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/844a0b425741f07cb233332405143931586bbb7d

Powered by Google App Engine
This is Rietveld 408576698