tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper_unittest.py - Issue 1428133005: [Telemetry] Allows concatenating multiple Disabled & Enabled decorators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper_unittest.py

Issue 1428133005: [Telemetry] Allows concatenating multiple Disabled & Enabled decorators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Dave's comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/image_processing/video_unittest.py ('k') | tools/telemetry/telemetry/internal/platform/profiler/vtune_profiler_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper_unittest.py

diff --git a/tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper_unittest.py b/tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper_unittest.py

index 0db4e5659c85141c2bcfda7007d6ab4fd3cbfa57..7e423232a58cdd89ab001ce90b1838d646d9bc32 100644

--- a/tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper_unittest.py

+++ b/tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper_unittest.py

@@ -201,7 +201,7 @@ class TestAndroidProfilingHelperTabTestCase(tab_test_case.TabTestCase):

# Test fails: crbug.com/437081

# @decorators.Enabled('android')

- @decorators.Disabled

+ @decorators.Disabled('all')

def testGetToolchainBinaryPath(self):

with tempfile.NamedTemporaryFile() as libc:

self._device.PullFile('/system/lib/libc.so', libc.name)