tools/perf/benchmarks/page_cycler.py - Issue 1428133005: [Telemetry] Allows concatenating multiple Disabled & Enabled decorators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 1428133005: [Telemetry] Allows concatenating multiple Disabled & Enabled decorators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Dave's comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/page_cycler.py

diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py

index 826a6afd788c61d596643f06cb8f8ae95728ae87..5886df267b36411968883e7d2a60b617d8246020 100644

--- a/tools/perf/benchmarks/page_cycler.py

+++ b/tools/perf/benchmarks/page_cycler.py

@@ -181,7 +181,7 @@ class PageCyclerTop10Mobile(_PageCycler):

stories.RemoveStory(found)

return stories

-@benchmark.Disabled

+@benchmark.Disabled('all')

class PageCyclerKeyMobileSites(_PageCycler):

"""Page load time benchmark for key mobile sites."""

page_set = page_sets.KeyMobileSitesPageSet

@@ -246,7 +246,7 @@ class PageCyclerBasicOopif(_PageCycler):

return 'page_cycler.basic_oopif'

-@benchmark.Disabled # crbug.com/443730

+@benchmark.Disabled('all') # crbug.com/443730

class PageCyclerBigJs(_PageCycler):

page_set = page_sets.BigJsPageSet

@classmethod

« no previous file with comments | « tools/perf/benchmarks/media.py ('k') | tools/perf/benchmarks/power.py » ('j') | no next file with comments »