Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: tools/perf/measurements/task_execution_time_unittest.py

Issue 1428133005: [Telemetry] Allows concatenating multiple Disabled & Enabled decorators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Dave's comment Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/text_selection.py ('k') | tools/telemetry/telemetry/decorators.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry import decorators 5 from telemetry import decorators
6 from telemetry.internal.results import page_test_results 6 from telemetry.internal.results import page_test_results
7 from telemetry.page import page as page_module 7 from telemetry.page import page as page_module
8 from telemetry.testing import options_for_unittests 8 from telemetry.testing import options_for_unittests
9 from telemetry.testing import page_test_test_case 9 from telemetry.testing import page_test_test_case
10 from telemetry.timeline import model as model_module 10 from telemetry.timeline import model as model_module
(...skipping 30 matching lines...) Expand all
41 def testSomeResultsReturnedFromDummyPage(self): 41 def testSomeResultsReturnedFromDummyPage(self):
42 self._GenerateDataForEmptyPageSet() 42 self._GenerateDataForEmptyPageSet()
43 43
44 results = self.RunMeasurement(self._measurement, 44 results = self.RunMeasurement(self._measurement,
45 self._page_set, 45 self._page_set,
46 options=self._options) 46 options=self._options)
47 47
48 self.assertGreater(len(results.all_page_specific_values), 0) 48 self.assertGreater(len(results.all_page_specific_values), 0)
49 49
50 # http://crbug.com/466994 50 # http://crbug.com/466994
51 @decorators.Disabled 51 @decorators.Disabled('all')
52 def testSlicesConformToRequiredNamingConventionsUsingDummyPage(self): 52 def testSlicesConformToRequiredNamingConventionsUsingDummyPage(self):
53 """This test ensures the presence of required keywords. 53 """This test ensures the presence of required keywords.
54 54
55 Some arbitrary keywords are required to generate the names of the top 10 55 Some arbitrary keywords are required to generate the names of the top 10
56 tasks. The code has a weak dependancy on 'src_func', 'class' and 'line' 56 tasks. The code has a weak dependancy on 'src_func', 'class' and 'line'
57 existing; if they exist in a slice's args they are used to generate a 57 existing; if they exist in a slice's args they are used to generate a
58 name, if they don't exists the code falls back to using the name of the 58 name, if they don't exists the code falls back to using the name of the
59 slice, which is less clear. 59 slice, which is less clear.
60 60
61 If the code has been refactored and these keywords no longer exist 61 If the code has been refactored and these keywords no longer exist
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 None, 265 None,
266 'category', 266 'category',
267 name, 267 name,
268 timestamp, 268 timestamp,
269 duration, 269 duration,
270 timestamp, 270 timestamp,
271 duration, 271 duration,
272 []) 272 [])
273 self._renderer_thread.all_slices.append(new_slice) 273 self._renderer_thread.all_slices.append(new_slice)
274 return new_slice 274 return new_slice
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/text_selection.py ('k') | tools/telemetry/telemetry/decorators.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698