Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1428133003: cc: Add SetNeedsOneBeginImplFrame to the Scheduler (Closed)

Created:
5 years, 1 month ago by danakj
Modified:
5 years, 1 month ago
Reviewers:
sunnyps, brianderson
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org, ajuma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add SetNeedsOneBeginImplFrame to the Scheduler This requests another BeginImplFrame to happen. Once the requests for new ones stop coming, the scheduler will put the begin frame source to sleep. This will be used to replace SetNeedsAnimate to request new frames while an animation wants to tick. BUG=522658 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f10a644d2cbccad0d5b80598326420ff1b827f17 Cr-Commit-Position: refs/heads/master@{#357667}

Patch Set 1 : snanimate: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -2 lines) Patch
M cc/scheduler/scheduler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 6 chunks +10 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 5 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
danakj
5 years, 1 month ago (2015-11-03 22:06:04 UTC) #6
brianderson
lgtm
5 years, 1 month ago (2015-11-03 22:19:19 UTC) #7
sunnyps
LGTM nit: Can we call this SetNeedsBeginFrameForAnimation instead of SetNeedsOneBeginImplFrame?
5 years, 1 month ago (2015-11-03 22:25:55 UTC) #8
danakj
On 2015/11/03 22:25:55, sunnyps wrote: > LGTM > > nit: Can we call this SetNeedsBeginFrameForAnimation ...
5 years, 1 month ago (2015-11-03 22:26:51 UTC) #9
sunnyps
On 2015/11/03 22:26:51, danakj wrote: > On 2015/11/03 22:25:55, sunnyps wrote: > > LGTM > ...
5 years, 1 month ago (2015-11-03 22:32:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428133003/20002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428133003/20002
5 years, 1 month ago (2015-11-03 22:48:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20002)
5 years, 1 month ago (2015-11-03 23:14:34 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 23:15:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f10a644d2cbccad0d5b80598326420ff1b827f17
Cr-Commit-Position: refs/heads/master@{#357667}

Powered by Google App Engine
This is Rietveld 408576698