| Index: src/mips/full-codegen-mips.cc
|
| diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc
|
| index df83019f15e4a9c349d425da19257592618f3d13..d416a3b8520ae8c21b112941a546b988b02bce87 100644
|
| --- a/src/mips/full-codegen-mips.cc
|
| +++ b/src/mips/full-codegen-mips.cc
|
| @@ -1694,11 +1694,11 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
|
| ASSERT(!CompileTimeValue::IsCompileTimeValue(property->value()));
|
| // Fall through.
|
| case ObjectLiteral::Property::COMPUTED:
|
| - if (key->handle()->IsInternalizedString()) {
|
| + if (key->value()->IsInternalizedString()) {
|
| if (property->emit_store()) {
|
| VisitForAccumulatorValue(value);
|
| __ mov(a0, result_register());
|
| - __ li(a2, Operand(key->handle()));
|
| + __ li(a2, Operand(key->value()));
|
| __ lw(a1, MemOperand(sp));
|
| Handle<Code> ic = is_classic_mode()
|
| ? isolate()->builtins()->StoreIC_Initialize()
|
| @@ -1834,10 +1834,7 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
|
| Expression* subexpr = subexprs->at(i);
|
| // If the subexpression is a literal or a simple materialized literal it
|
| // is already set in the cloned array.
|
| - if (subexpr->AsLiteral() != NULL ||
|
| - CompileTimeValue::IsCompileTimeValue(subexpr)) {
|
| - continue;
|
| - }
|
| + if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue;
|
|
|
| if (!result_saved) {
|
| __ push(v0); // array literal
|
| @@ -2001,14 +1998,28 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
|
| __ push(result_register());
|
| // Fall through.
|
| case Yield::INITIAL: {
|
| - VisitForStackValue(expr->generator_object());
|
| - __ CallRuntime(Runtime::kSuspendJSGeneratorObject, 1);
|
| - __ lw(context_register(),
|
| - MemOperand(fp, StandardFrameConstants::kContextOffset));
|
| + Label suspend, continuation, post_runtime, resume;
|
|
|
| - Label resume;
|
| - __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
|
| - __ Branch(&resume, ne, result_register(), Operand(at));
|
| + __ jmp(&suspend);
|
| +
|
| + __ bind(&continuation);
|
| + __ jmp(&resume);
|
| +
|
| + __ bind(&suspend);
|
| + VisitForAccumulatorValue(expr->generator_object());
|
| + ASSERT(continuation.pos() > 0 && Smi::IsValid(continuation.pos()));
|
| + __ li(a1, Operand(Smi::FromInt(continuation.pos())));
|
| + __ sw(a1, FieldMemOperand(v0, JSGeneratorObject::kContinuationOffset));
|
| + __ sw(cp, FieldMemOperand(v0, JSGeneratorObject::kContextOffset));
|
| + __ mov(a1, cp);
|
| + __ RecordWriteField(v0, JSGeneratorObject::kContextOffset, a1, a2,
|
| + kRAHasBeenSaved, kDontSaveFPRegs);
|
| + __ Addu(a1, fp, Operand(StandardFrameConstants::kExpressionsOffset));
|
| + __ Branch(&post_runtime, eq, sp, Operand(a1));
|
| + __ push(v0); // generator object
|
| + __ CallRuntime(Runtime::kSuspendJSGeneratorObject, 1);
|
| + __ lw(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
|
| + __ bind(&post_runtime);
|
| __ pop(result_register());
|
| EmitReturnSequence();
|
|
|
| @@ -2036,7 +2047,8 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
|
| // [sp + 1 * kPointerSize] iter
|
| // [sp + 0 * kPointerSize] g
|
|
|
| - Label l_catch, l_try, l_resume, l_next, l_call, l_loop;
|
| + Label l_catch, l_try, l_suspend, l_continuation, l_resume;
|
| + Label l_next, l_call, l_loop;
|
| // Initial send value is undefined.
|
| __ LoadRoot(a0, Heap::kUndefinedValueRootIndex);
|
| __ Branch(&l_next);
|
| @@ -2059,14 +2071,23 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
|
| __ PushTryHandler(StackHandler::CATCH, expr->index());
|
| const int handler_size = StackHandlerConstants::kSize;
|
| __ push(a0); // result
|
| - __ lw(a3, MemOperand(sp, (0 + 1) * kPointerSize + handler_size)); // g
|
| - __ push(a3); // g
|
| - __ CallRuntime(Runtime::kSuspendJSGeneratorObject, 1);
|
| + __ jmp(&l_suspend);
|
| + __ bind(&l_continuation);
|
| __ mov(a0, v0);
|
| - __ lw(context_register(),
|
| - MemOperand(fp, StandardFrameConstants::kContextOffset));
|
| - __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
|
| - __ Branch(&l_resume, ne, a0, Operand(at));
|
| + __ jmp(&l_resume);
|
| + __ bind(&l_suspend);
|
| + const int generator_object_depth = kPointerSize + handler_size;
|
| + __ lw(a0, MemOperand(sp, generator_object_depth));
|
| + __ push(a0); // g
|
| + ASSERT(l_continuation.pos() > 0 && Smi::IsValid(l_continuation.pos()));
|
| + __ li(a1, Operand(Smi::FromInt(l_continuation.pos())));
|
| + __ sw(a1, FieldMemOperand(a0, JSGeneratorObject::kContinuationOffset));
|
| + __ sw(cp, FieldMemOperand(a0, JSGeneratorObject::kContextOffset));
|
| + __ mov(a1, cp);
|
| + __ RecordWriteField(a0, JSGeneratorObject::kContextOffset, a1, a2,
|
| + kRAHasBeenSaved, kDontSaveFPRegs);
|
| + __ CallRuntime(Runtime::kSuspendJSGeneratorObject, 1);
|
| + __ lw(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
|
| __ pop(v0); // result
|
| EmitReturnSequence();
|
| __ mov(a0, v0);
|
| @@ -2142,7 +2163,7 @@ void FullCodeGenerator::EmitGeneratorResume(Expression *generator,
|
| __ LoadRoot(a2, Heap::kTheHoleValueRootIndex);
|
| Label push_argument_holes, push_frame;
|
| __ bind(&push_argument_holes);
|
| - __ Subu(a3, a3, Operand(1));
|
| + __ Subu(a3, a3, Operand(Smi::FromInt(1)));
|
| __ Branch(&push_frame, lt, a3, Operand(zero_reg));
|
| __ push(a2);
|
| __ jmp(&push_argument_holes);
|
| @@ -2247,7 +2268,7 @@ void FullCodeGenerator::EmitNamedPropertyLoad(Property* prop) {
|
| SetSourcePosition(prop->position());
|
| Literal* key = prop->key()->AsLiteral();
|
| __ mov(a0, result_register());
|
| - __ li(a2, Operand(key->handle()));
|
| + __ li(a2, Operand(key->value()));
|
| // Call load IC. It has arguments receiver and property name a0 and a2.
|
| Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
|
| CallIC(ic, RelocInfo::CODE_TARGET, prop->PropertyFeedbackId());
|
| @@ -2409,7 +2430,7 @@ void FullCodeGenerator::EmitAssignment(Expression* expr) {
|
| VisitForAccumulatorValue(prop->obj());
|
| __ mov(a1, result_register());
|
| __ pop(a0); // Restore value.
|
| - __ li(a2, Operand(prop->key()->AsLiteral()->handle()));
|
| + __ li(a2, Operand(prop->key()->AsLiteral()->value()));
|
| Handle<Code> ic = is_classic_mode()
|
| ? isolate()->builtins()->StoreIC_Initialize()
|
| : isolate()->builtins()->StoreIC_Initialize_Strict();
|
| @@ -2540,7 +2561,7 @@ void FullCodeGenerator::EmitNamedPropertyAssignment(Assignment* expr) {
|
| // Record source code position before IC call.
|
| SetSourcePosition(expr->position());
|
| __ mov(a0, result_register()); // Load the value.
|
| - __ li(a2, Operand(prop->key()->AsLiteral()->handle()));
|
| + __ li(a2, Operand(prop->key()->AsLiteral()->value()));
|
| __ pop(a1);
|
|
|
| Handle<Code> ic = is_classic_mode()
|
| @@ -2818,7 +2839,7 @@ void FullCodeGenerator::VisitCall(Call* expr) {
|
| }
|
| if (property->key()->IsPropertyName()) {
|
| EmitCallWithIC(expr,
|
| - property->key()->AsLiteral()->handle(),
|
| + property->key()->AsLiteral()->value(),
|
| RelocInfo::CODE_TARGET);
|
| } else {
|
| EmitKeyedCallWithIC(expr, property->key());
|
| @@ -3423,7 +3444,7 @@ void FullCodeGenerator::EmitDateField(CallRuntime* expr) {
|
| ZoneList<Expression*>* args = expr->arguments();
|
| ASSERT(args->length() == 2);
|
| ASSERT_NE(NULL, args->at(1)->AsLiteral());
|
| - Smi* index = Smi::cast(*(args->at(1)->AsLiteral()->handle()));
|
| + Smi* index = Smi::cast(*(args->at(1)->AsLiteral()->value()));
|
|
|
| VisitForAccumulatorValue(args->at(0)); // Load the object.
|
|
|
| @@ -3855,7 +3876,7 @@ void FullCodeGenerator::EmitGetFromCache(CallRuntime* expr) {
|
| ASSERT_EQ(2, args->length());
|
|
|
| ASSERT_NE(NULL, args->at(0)->AsLiteral());
|
| - int cache_id = Smi::cast(*(args->at(0)->AsLiteral()->handle()))->value();
|
| + int cache_id = Smi::cast(*(args->at(0)->AsLiteral()->value()))->value();
|
|
|
| Handle<FixedArray> jsfunction_result_caches(
|
| isolate()->native_context()->jsfunction_result_caches());
|
| @@ -4530,7 +4551,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
|
| break;
|
| case NAMED_PROPERTY: {
|
| __ mov(a0, result_register()); // Value.
|
| - __ li(a2, Operand(prop->key()->AsLiteral()->handle())); // Name.
|
| + __ li(a2, Operand(prop->key()->AsLiteral()->value())); // Name.
|
| __ pop(a1); // Receiver.
|
| Handle<Code> ic = is_classic_mode()
|
| ? isolate()->builtins()->StoreIC_Initialize()
|
|
|