Clean up Windows GN toolchains

Clean up Windows GN toolchains.

Properly sets up 64-bit cross compiles when targeting 32-bit CPUs on Windows.

Enables the cloud print portmon library 64-bit cross-compile.

Removes vc_bin_dir build argument. This doesn't play nicely with multiple architectures in a build. If we need this, a more expressive build setting will need to be invented.

Committed: https://crrev.com/6bbfd4e271e88644369b01f8b43a88f09adda155
Cr-Commit-Position: refs/heads/master@{#358910}

[brettw, 2015-11-10 19:31:14]

Description was changed from

==========
Clean up Windows toolchains
==========

to

==========
Clean up Windows GN toolchains

Removes vc_bin_dir build argument. This doesn't play nicely with multiple
architectures in a build. If we need this, a more expressive build setting will
need to be invented.
==========

[brettw, 2015-11-10 19:31:21]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-10 19:34:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428123003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428123003/20001

[brettw, 2015-11-10 20:04:08]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2015-11-10 20:04:16]

Description was changed from

==========
Clean up Windows GN toolchains

Removes vc_bin_dir build argument. This doesn't play nicely with multiple
architectures in a build. If we need this, a more expressive build setting will
need to be invented.
==========

to

==========
Clean up Windows GN toolchains.

Properly sets up 64-bit cross compiles when targeting 32-bit CPUs on Windows.

Enables the cloud print portmon library 64-bit cross-compile.

Removes vc_bin_dir build argument. This doesn't play nicely with multiple
architectures in a build. If we need this, a more expressive build setting will
need to be invented.
==========

[brettw, 2015-11-10 20:04:16]

brettw@chromium.org changed reviewers:
- scottmg@chromium.org

[brettw, 2015-11-10 20:04:25]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[commit-bot: I haz the power, 2015-11-10 20:19:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-10 20:19:05]

Dry run: This issue passed the CQ dry run.

[scottmg, 2015-11-10 20:22:21]

lgtm

https://codereview.chromium.org/1428123003/diff/20001/build/toolchain/win/BUI...
File build/toolchain/win/BUILD.gn (right):

https://codereview.chromium.org/1428123003/diff/20001/build/toolchain/win/BUI...
build/toolchain/win/BUILD.gn:293: cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\""
Was anyone using this? I guess it'll have to be amd64_arm or something, but I
don't know where that would have been coming from before if it worked.

[brettw, 2015-11-10 21:36:13]

https://codereview.chromium.org/1428123003/diff/20001/build/toolchain/win/BUI...
File build/toolchain/win/BUILD.gn (right):

https://codereview.chromium.org/1428123003/diff/20001/build/toolchain/win/BUI...
build/toolchain/win/BUILD.gn:293: cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\""
Some people did this stuff and seemed to be working on a custom fork. Given that
we have a bunch of BUILDCONFIG.gn stuff. If this isn't fixed eventually I'll
delete all the code, but it seemed unreasonable to delete it entirely now
without giving them a chance to fix it.

[brettw, 2015-11-10 21:36:20]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-10 21:36:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1428123003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1428123003/20001

[commit-bot: I haz the power, 2015-11-10 21:42:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-10 21:43:22]

Patchset 2 (id:??) landed as
https://crrev.com/6bbfd4e271e88644369b01f8b43a88f09adda155
Cr-Commit-Position: refs/heads/master@{#358910}