Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1428093005: Make function type checks for types returned by typed JS interop pass for functions with <=10 argum… (Closed)

Created:
5 years, 1 month ago by Jacob
Modified:
5 years, 1 month ago
Reviewers:
Leaf, sra1
CC:
reviews_dartlang.org, goderbauer
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make function type checks for types returned by typed JS interop pass for functions with <=10 arguments. BUG= R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/12e94fc1d92995da5ebedbd345cc888727d39e47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M sdk/lib/js/dartium/js_dartium.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/html/js_typed_interop_test.dart View 4 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
5 years, 1 month ago (2015-11-04 01:42:16 UTC) #2
Jacob
5 years, 1 month ago (2015-11-04 01:44:11 UTC) #4
Leaf
lgtm
5 years, 1 month ago (2015-11-04 01:57:41 UTC) #5
Jacob
5 years, 1 month ago (2015-11-04 01:58:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
12e94fc1d92995da5ebedbd345cc888727d39e47 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698