Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1428053002: Revert of Make SkBlurImageFilter capable of cropping during blur (Closed)

Created:
5 years, 1 month ago by Stephen White
Modified:
5 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, robertphillips
Base URL:
senorblanco-linux.mon:src/skia@blur-applyCropRect4
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make SkBlurImageFilter capable of cropping during blur (patchset #16 id:400001 of https://codereview.chromium.org/1415653003/ ) Reason for revert: ASAN failures (see https://codereview.chromium.org/1415653003/) Original issue's description: > Make SkBlurImageFilter capable of cropping during blur (raster path) > > SkBlurImageFilter can currently only process a source image > which is larger than or equal to the destination rect. If > the source image (or crop rect) is smaller, it is padded > out to dest size with transparent black via the 6-param > version of applyCropRect(). > > Fixing this requires modifying all the flavours of RGBA > box_blur() to accept a src crop rect. > > BUG=skia:4502, skia:4526 > CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot;client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/1b82ceb737c73327412f2e8a91748481e1aec9e4 TBR=mtklein@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4502, skia:4526 Committed: https://skia.googlesource.com/skia/+/8de01c642c145e9a6e0b9d68066e9fe63c4c5492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -94 lines) Patch
M src/core/SkOpts.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 5 chunks +21 lines, -23 lines 0 comments Download
M src/opts/SkBlurImageFilter_opts.h View 9 chunks +17 lines, -70 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Stephen White
Created Revert of Make SkBlurImageFilter capable of cropping during blur
5 years, 1 month ago (2015-11-02 19:56:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428053002/1
5 years, 1 month ago (2015-11-02 19:56:11 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 19:56:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8de01c642c145e9a6e0b9d68066e9fe63c4c5492

Powered by Google App Engine
This is Rietveld 408576698