Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: ui/gfx/icon_util.cc

Issue 1428003002: More const int definitions for VC++ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add periods. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/fenced_allocator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/icon_util.cc
diff --git a/ui/gfx/icon_util.cc b/ui/gfx/icon_util.cc
index f9758d39f67626b02bf8a1f470ff8338452ed793..7ceb6edad62b5bd90cb5f0e74bd7f589b8bfe1b4 100644
--- a/ui/gfx/icon_util.cc
+++ b/ui/gfx/icon_util.cc
@@ -163,6 +163,12 @@ const int IconUtil::kIconDimensions[] = {
const size_t IconUtil::kNumIconDimensions = arraysize(kIconDimensions);
const size_t IconUtil::kNumIconDimensionsUpToMediumSize = 9;
+// VS 2015 and above allow these definitions and in this case require them.
+#if !defined(_MSC_VER) || _MSC_VER >= 1900
danakj 2015/10/30 20:40:37 Why is this !defined || VER >= 1900, but the one i
brucedawson 2015/10/30 20:51:37 The one in base is in a _win only file. But, I don
+const int IconUtil::kLargeIconSize;
+const int IconUtil::kMediumIconSize;
+#endif
+
HICON IconUtil::CreateHICONFromSkBitmap(const SkBitmap& bitmap) {
// Only 32 bit ARGB bitmaps are supported. We also try to perform as many
// validations as we can on the bitmap.
« no previous file with comments | « gpu/command_buffer/client/fenced_allocator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698