Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 14280003: Remove more unused marcos. (Closed)

Created:
7 years, 8 months ago by lgombos
Modified:
7 years, 8 months ago
CC:
blink-reviews, loislo+blink_chromium.org, jeez, yurys+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove more unused marcos. Remove the following macros: PLATFORM(XX), BUILDING_ON_XX, BUILDING_CHROMIUM, TARGETING_XX, USE(SKIA), BUILDING_WITH_CMAKE, BUILDING_WEBKIT2. These are no longer needed for blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148781

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -133 lines) Patch
M Source/wtf/Platform.h View 3 chunks +0 lines, -26 lines 0 comments Download
M Source/wtf/wtf.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M Tools/DumpRenderTree/DumpRenderTree.h View 1 chunk +0 lines, -14 lines 0 comments Download
M Tools/TestWebKitAPI/JavaScriptTest.h View 2 chunks +0 lines, -15 lines 0 comments Download
M Tools/TestWebKitAPI/PlatformUtilities.h View 2 chunks +0 lines, -15 lines 0 comments Download
M Tools/TestWebKitAPI/PlatformWebView.h View 2 chunks +0 lines, -37 lines 1 comment Download
M Tools/TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Tools/TestWebKitAPI/config.h View 4 chunks +0 lines, -15 lines 1 comment Download
M Tools/TestWebKitAPI/mac/InjectedBundleControllerMac.mm View 1 chunk +0 lines, -4 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
lgombos
More cleanup.
7 years, 8 months ago (2013-04-20 21:54:40 UTC) #1
lgombos
On 2013/04/20 21:54:40, lgombos wrote: > More cleanup. Some files (e.g. PlatformUtilities.h) are probably not ...
7 years, 8 months ago (2013-04-20 21:57:27 UTC) #2
abarth-chromium
LGTM I agree that we should remove the other files in another CL. https://codereview.chromium.org/14280003/diff/1/Tools/TestWebKitAPI/PlatformWebView.h File ...
7 years, 8 months ago (2013-04-20 22:46:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14280003/1
7 years, 8 months ago (2013-04-20 23:27:22 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 23:42:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14280003/1
7 years, 8 months ago (2013-04-20 23:51:27 UTC) #6
commit-bot: I haz the power
Change committed as 148781
7 years, 8 months ago (2013-04-21 00:08:14 UTC) #7
Nico
\o/ If you want to delete more stuff: https://chromiumcodereview.appspot.com/14280003/diff/1/Tools/TestWebKitAPI/config.h File Tools/TestWebKitAPI/config.h (right): https://chromiumcodereview.appspot.com/14280003/diff/1/Tools/TestWebKitAPI/config.h#newcode26 Tools/TestWebKitAPI/config.h:26: #if ...
7 years, 8 months ago (2013-04-21 01:26:42 UTC) #8
abarth-chromium
7 years, 8 months ago (2013-04-21 01:30:02 UTC) #9
Message was sent while issue was closed.
Really we should delete all of TestWebKitAPI by moving the tests into
webkit_unit_tests.

Powered by Google App Engine
This is Rietveld 408576698