Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1427993004: remove I422ToBGRA and use I422ToRGBA internally (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin, fbarchard, xhwang
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

remove I422ToBGRA and use I422ToRGBA internally Removes low levels for I420ToBGRA and I420ToRAW and reimplements them as I420ToRGBA and I420ToRGB24 with transposed color matrix. Adds unittests that do 1 step conversion vs 2 steps to test end swapping versions match direct conversions. R=harryjin@google.com BUG=libyuv:518 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/2c7aa0070a2944fa311367f3b5ce4c8b069f1104

Patch Set 1 #

Patch Set 2 : remove raw low level and add 2 step test #

Patch Set 3 : lint fixes for warnings about comments in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -968 lines) Patch
M README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 1 19 chunks +0 lines, -107 lines 0 comments Download
M include/libyuv/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M source/convert_from.cc View 1 5 chunks +77 lines, -139 lines 0 comments Download
M source/planar_functions.cc View 2 chunks +46 lines, -96 lines 0 comments Download
M source/row_any.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M source/row_common.cc View 1 3 chunks +0 lines, -72 lines 0 comments Download
M source/row_gcc.cc View 1 4 chunks +0 lines, -172 lines 0 comments Download
M source/row_mips.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M source/row_neon.cc View 1 2 chunks +0 lines, -61 lines 0 comments Download
M source/row_neon64.cc View 1 2 chunks +0 lines, -63 lines 0 comments Download
M source/row_win.cc View 1 3 chunks +0 lines, -149 lines 0 comments Download
M unit_test/convert_test.cc View 1 2 1 chunk +97 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
fbarchard1
5 years, 1 month ago (2015-11-02 08:23:26 UTC) #1
fbarchard
13 files changed, 222 insertions(+), 968 deletions(-) [==========] 950 tests from 6 test cases ran. ...
5 years, 1 month ago (2015-11-02 12:06:23 UTC) #5
harryjin
lgtm
5 years, 1 month ago (2015-11-02 17:47:58 UTC) #6
fbarchard1
5 years, 1 month ago (2015-11-02 18:24:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2c7aa0070a2944fa311367f3b5ce4c8b069f1104 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698