Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1427973009: Reland of "Remove setVoiceSearchSupported part of EmbeddedSearch SearchBox API." (patchset #4 id:60… (Closed)

Created:
5 years, 1 month ago by Evan Stade
Modified:
5 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, oshima+watch_chromium.org, derat+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, chromium-apps-reviews_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, tfarina, kmadhusu+watch_chromium.org, James Su, Jered, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Remove setVoiceSearchSupported part of EmbeddedSearch SearchBox API." (patchset #4 id:60001 of https://codereview.chromium.org/1428423002/ ) This reverts commit c3f9baf19272988820ae7b with a fix to chrome_dll.rc BUG=522168 TBR=oshima@chromium.org,msw@chromium.org,samarth@chromium.org Committed: https://crrev.com/dcfba32ea778c18e55b9b56e69690954a83aa114 Cr-Commit-Position: refs/heads/master@{#358840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -473 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/chrome_dll.rc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/app/theme/default_100_percent/common/omnibox_mic_search.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_mic_search.png View Binary file 0 comments Download
D chrome/app/theme/material_100_percent/common/omnibox_mic_search.png View Binary file 0 comments Download
D chrome/app/theme/material_200_percent/common/omnibox_mic_search.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/global_keyboard_shortcuts_mac.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 6 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 8 chunks +0 lines, -22 lines 0 comments Download
D chrome/browser/ui/cocoa/location_bar/mic_search_decoration.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/ui/cocoa/location_bar/mic_search_decoration.mm View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router.h View 5 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_policy_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_policy_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_policy_unittest.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 5 chunks +0 lines, -53 lines 0 comments Download
M chrome/browser/ui/search/search_model.h View 3 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/ui/search/search_model.cc View 2 chunks +4 lines, -27 lines 0 comments Download
M chrome/browser/ui/search/search_model_unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/view_ids.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 7 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 12 chunks +5 lines, -58 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/renderer/resources/extensions/searchbox_api.js View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 5 chunks +0 lines, -39 lines 0 comments Download
M chrome/test/data/instant_extended.html View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/test/data/instant_extended_ntp.html View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Evan Stade
TBR original reviewers +grt for chrome/app/chrome_dll.rc (only difference from original patch)
5 years, 1 month ago (2015-11-09 23:09:14 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427973009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427973009/1
5 years, 1 month ago (2015-11-09 23:11:58 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-10 01:00:36 UTC) #7
grt (UTC plus 2)
lgtm
5 years, 1 month ago (2015-11-10 15:28:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427973009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427973009/1
5 years, 1 month ago (2015-11-10 16:49:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 16:54:45 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 16:55:46 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dcfba32ea778c18e55b9b56e69690954a83aa114
Cr-Commit-Position: refs/heads/master@{#358840}

Powered by Google App Engine
This is Rietveld 408576698