Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1427953002: [Tracing] Remove fields from AllocationContext (Closed)

Created:
5 years, 1 month ago by Ruud van Asseldonk
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Tracing] Remove fields from AllocationContext These fields will return later on in the form of a trait set as proposed in the Task Traits proposal. The |AllocationContextTracker| will not keep track of general-purpose fields. BUG=524631 Committed: https://crrev.com/2983eaac91b9edbd693b6955bde26e76741879d3 Cr-Commit-Position: refs/heads/master@{#357095}

Patch Set 1 #

Patch Set 2 : Add initializers to test to make MSVC happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -55 lines) Patch
M base/trace_event/memory_profiler_allocation_context.h View 4 chunks +5 lines, -20 lines 0 comments Download
M base/trace_event/memory_profiler_allocation_context.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M base/trace_event/memory_profiler_allocation_register_unittest.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ruud van Asseldonk
We still need to do a more thorough cleanup of this file, but this is ...
5 years, 1 month ago (2015-10-30 11:10:34 UTC) #2
Primiano Tucci (use gerrit)
lgtm
5 years, 1 month ago (2015-10-30 11:13:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427953002/20001
5 years, 1 month ago (2015-10-30 14:07:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 14:14:15 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 14:15:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2983eaac91b9edbd693b6955bde26e76741879d3
Cr-Commit-Position: refs/heads/master@{#357095}

Powered by Google App Engine
This is Rietveld 408576698