Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1427913006: Remove _FPDF_ByteStringFromHex as it is unused (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove _FPDF_ByteStringFromHex as it is unused There are no uses of this method, I also checked the XFA branch and there don't appear to be any uses there either. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e65be3a55628294d0f45da456d856b4539f0cb15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dsinclair
PTAL.
5 years, 1 month ago (2015-11-02 19:16:04 UTC) #2
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-02 19:18:43 UTC) #3
dsinclair
5 years, 1 month ago (2015-11-02 19:20:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e65be3a55628294d0f45da456d856b4539f0cb15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698