chrome/browser/engagement/site_engagement_metrics.h - Issue 1427913002: Implement media playing engagement detection for the site engagement service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_metrics.h

Issue 1427913002: Implement media playing engagement detection for the site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@user-input-event

Patch Set: Addressing nits Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/engagement/site_engagement_helper_unittest.cc ('k') | chrome/browser/engagement/site_engagement_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_metrics.h

diff --git a/chrome/browser/engagement/site_engagement_metrics.h b/chrome/browser/engagement/site_engagement_metrics.h

index 1360cef5f18c5a01420c772e767d340e738cfd69..f4eaa7f8384b31313c748f0093a7edd795150244 100644

--- a/chrome/browser/engagement/site_engagement_metrics.h

+++ b/chrome/browser/engagement/site_engagement_metrics.h

@@ -22,6 +22,8 @@ class SiteEngagementMetrics {

ENGAGEMENT_MOUSE,

ENGAGEMENT_TOUCH_GESTURE,

ENGAGEMENT_WHEEL,

+ ENGAGEMENT_MEDIA_HIDDEN,

+ ENGAGEMENT_MEDIA_VISIBLE,

ENGAGEMENT_LAST,

};