Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6882)

Unified Diff: chrome/browser/engagement/site_engagement_service.cc

Issue 1427913002: Implement media playing engagement detection for the site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@user-input-event
Patch Set: Tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service.cc
diff --git a/chrome/browser/engagement/site_engagement_service.cc b/chrome/browser/engagement/site_engagement_service.cc
index d19f37c88d31cb29d3ad95ce11033acaa55f2ba4..ef59192e9e0f4e03088e8639be6b6b4ca2454390 100644
--- a/chrome/browser/engagement/site_engagement_service.cc
+++ b/chrome/browser/engagement/site_engagement_service.cc
@@ -102,6 +102,8 @@ const double SiteEngagementScore::kMaxPoints = 100;
double SiteEngagementScore::g_max_points_per_day = 5;
double SiteEngagementScore::g_navigation_points = 0.5;
double SiteEngagementScore::g_user_input_points = 0.05;
+double SiteEngagementScore::g_visible_media_playing_points = 0.02;
+double SiteEngagementScore::g_hidden_media_playing_points = 0.01;
int SiteEngagementScore::g_decay_period_in_days = 7;
double SiteEngagementScore::g_decay_points = 5;
@@ -318,6 +320,17 @@ void SiteEngagementService::HandleUserInput(
RecordMetrics();
}
+void SiteEngagementService::HandleMediaPlaying(const GURL& url,
+ bool is_hidden) {
+ SiteEngagementMetrics::RecordEngagement(
+ is_hidden ? SiteEngagementMetrics::ENGAGEMENT_MEDIA_HIDDEN
+ : SiteEngagementMetrics::ENGAGEMENT_MEDIA_VISIBLE);
+ AddPoints(url, is_hidden
+ ? SiteEngagementScore::g_hidden_media_playing_points
+ : SiteEngagementScore::g_visible_media_playing_points);
+ RecordMetrics();
+}
+
double SiteEngagementService::GetScore(const GURL& url) {
HostContentSettingsMap* settings_map =
HostContentSettingsMapFactory::GetForProfile(profile_);

Powered by Google App Engine
This is Rietveld 408576698