Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 1427893002: Handle contained declarations for interfaces and structs. (Closed)

Created:
5 years, 1 month ago by azani
Modified:
5 years, 1 month ago
Reviewers:
rudominer
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Handle contained declarations for interfaces and structs. R=rudominer@chromium.org, rudominer BUG= #461 Committed: https://chromium.googlesource.com/external/mojo/+/403223670af9546ec01b19b0e15774cf2e998de3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -5 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py View 3 chunks +31 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py View 2 chunks +40 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
azani
5 years, 1 month ago (2015-10-29 21:43:25 UTC) #1
rudominer
lgtm
5 years, 1 month ago (2015-10-29 21:52:29 UTC) #2
azani
5 years, 1 month ago (2015-10-29 21:55:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
403223670af9546ec01b19b0e15774cf2e998de3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698