Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1427873002: Rename ManagedFullScreenBubbleDelegateView (Closed)

Created:
5 years, 1 month ago by Evan Stade
Modified:
5 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@moregreyness
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ManagedFullScreenBubbleDelegateView The current name makes it sound like it has something to do with: - managed profiles - the bubble you see when entering full screen - definitely not the bubble you see when you click a location bar icon The new name, LocationBarBubbleDelegateView, describes how it's used. BUG=none Committed: https://crrev.com/cad09d4a7e9e97db541873f8b592b9049fd2290f Cr-Commit-Position: refs/heads/master@{#356971}

Patch Set 1 #

Patch Set 2 : fix it #

Total comments: 2

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -157 lines) Patch
M chrome/browser/ui/views/autofill/save_card_bubble_views.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/save_card_bubble_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h View 3 chunks +13 lines, -12 lines 0 comments Download
A + chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc View 1 2 4 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Evan Stade
5 years, 1 month ago (2015-10-29 21:26:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427873002/20001
5 years, 1 month ago (2015-10-29 21:27:56 UTC) #4
msw
lgtm with random optional nit. https://codereview.chromium.org/1427873002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc (right): https://codereview.chromium.org/1427873002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc#newcode53 chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:53: int bubble_half_width = width() ...
5 years, 1 month ago (2015-10-29 21:41:03 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/50753) chromeos_daisy_chromium_compile_only_ng on ...
5 years, 1 month ago (2015-10-29 21:51:04 UTC) #7
Evan Stade
https://codereview.chromium.org/1427873002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc File chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc (right): https://codereview.chromium.org/1427873002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc#newcode53 chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc:53: int bubble_half_width = width() / 2; On 2015/10/29 21:41:03, ...
5 years, 1 month ago (2015-10-29 21:54:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427873002/40001
5 years, 1 month ago (2015-10-29 21:55:49 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-29 22:53:55 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 22:55:32 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cad09d4a7e9e97db541873f8b592b9049fd2290f
Cr-Commit-Position: refs/heads/master@{#356971}

Powered by Google App Engine
This is Rietveld 408576698