Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1427863002: Token stream iterator improvement (Closed)

Created:
5 years, 1 month ago by hausner
Modified:
5 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Token stream iterator improvement Eliminate the double indirection in accessing the token object array. It has no measurable effect, unfortunately :) BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/7c924f0a25b83ce9c3bf96e5dbbee314ca2f0eff

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M runtime/vm/object.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hausner
5 years, 1 month ago (2015-10-29 20:51:09 UTC) #3
siva
lgtm
5 years, 1 month ago (2015-10-29 21:49:48 UTC) #4
hausner
5 years, 1 month ago (2015-10-29 23:36:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7c924f0a25b83ce9c3bf96e5dbbee314ca2f0eff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698