Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1427843009: Fix crash about mask layers (Closed)

Created:
5 years, 1 month ago by Xianzhu
Modified:
5 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash about mask layers The return value of CompositedLayerMapping::updateChildClippingMaskLayer() only indicates if m_childClippingMaskLayer is changed. We need to check other conditions to update the references to it. BUG=553045 TEST=CompositedLayerMappingTest.ClippingMaskLayer Committed: https://crrev.com/4a2b26ac90fd59505ee54da4948a327da00ff85c Cr-Commit-Position: refs/heads/master@{#358738}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : Real fix of the issue in Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -23 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 3 3 chunks +37 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Xianzhu
5 years, 1 month ago (2015-11-09 20:25:26 UTC) #2
chrishtr
https://codereview.chromium.org/1427843009/diff/20001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp File third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp (right): https://codereview.chromium.org/1427843009/diff/20001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp#newcode484 third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp:484: if (hasClipPath) { Is this and the below just ...
5 years, 1 month ago (2015-11-09 22:24:51 UTC) #3
Xianzhu
https://codereview.chromium.org/1427843009/diff/20001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp File third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp (right): https://codereview.chromium.org/1427843009/diff/20001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp#newcode511 third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp:511: scrollingLayer()->setMaskLayer(layerToApplyChildClippingMask == clippingLayer() ? m_childClippingMaskLayer.get() : nullptr); The above ...
5 years, 1 month ago (2015-11-09 22:47:24 UTC) #4
Xianzhu
5 years, 1 month ago (2015-11-09 22:47:27 UTC) #5
Xianzhu
https://codereview.chromium.org/1427843009/diff/20001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp File third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp (right): https://codereview.chromium.org/1427843009/diff/20001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp#newcode511 third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp:511: scrollingLayer()->setMaskLayer(layerToApplyChildClippingMask == clippingLayer() ? m_childClippingMaskLayer.get() : nullptr); On 2015/11/09 ...
5 years, 1 month ago (2015-11-09 22:51:57 UTC) #6
chrishtr
lgtm
5 years, 1 month ago (2015-11-09 23:14:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427843009/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427843009/60001
5 years, 1 month ago (2015-11-09 23:16:27 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-10 01:49:37 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 01:51:21 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4a2b26ac90fd59505ee54da4948a327da00ff85c
Cr-Commit-Position: refs/heads/master@{#358738}

Powered by Google App Engine
This is Rietveld 408576698