Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 1427803004: GTK: Apply browser theme to TYPE_CONTROL windows (Closed)

Created:
5 years, 1 month ago by Evan Stade
Modified:
5 years, 1 month ago
Reviewers:
msw, Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GTK: Apply browser theme to TYPE_CONTROL windows This fixes the find bar view. I don't know what other, if any, UI surfaces are affected. Before this patch both the current and the MD findbar always use the system theme, but this looks broken because the find bar is part of the top browser Chrome. With this patch, the findbar will only use the system theme if the whole browser is in GTK theme mode. BUG=512443 Committed: https://crrev.com/e9ba2047516423ab0c4da5172b5dbc221a412ceb Cr-Commit-Position: refs/heads/master@{#356995}

Patch Set 1 #

Patch Set 2 : relative ps #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 3 chunks +9 lines, -6 lines 2 comments Download

Messages

Total messages: 13 (4 generated)
Evan Stade
+erg for review +msw for OWNERS
5 years, 1 month ago (2015-10-29 22:59:08 UTC) #2
Evan Stade
https://codereview.chromium.org/1427803004/diff/20001/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc File chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc (right): https://codereview.chromium.org/1427803004/diff/20001/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc#newcode129 chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc:129: bool should_open_ash = false; p.s. this change was just ...
5 years, 1 month ago (2015-10-29 22:59:43 UTC) #3
Elliot Glaysher
lgtm https://codereview.chromium.org/1427803004/diff/20001/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc File chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc (right): https://codereview.chromium.org/1427803004/diff/20001/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc#newcode129 chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc:129: bool should_open_ash = false; On 2015/10/29 22:59:43, Evan ...
5 years, 1 month ago (2015-10-29 23:04:51 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427803004/20001
5 years, 1 month ago (2015-10-29 23:11:13 UTC) #6
msw
lgtm
5 years, 1 month ago (2015-10-29 23:51:31 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-30 00:03:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427803004/20001
5 years, 1 month ago (2015-10-30 00:09:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 00:14:04 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 00:14:45 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9ba2047516423ab0c4da5172b5dbc221a412ceb
Cr-Commit-Position: refs/heads/master@{#356995}

Powered by Google App Engine
This is Rietveld 408576698