Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1427803003: Vector ICs: Allow for more IC kinds. (Closed)

Created:
5 years, 1 month ago by mvstanton
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Igor Sheludko
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Vector ICs: Allow for more IC kinds. We have plans to create more ICs, and we are out of bits to represent the Kind in the flags field of the code object. The InlineCacheState can lose a bit because it no longer needs the DEFAULT state. That state existed as a way to detect errors where code incorrectly looked at a vector IC stub's InlineCacheState instead of correctly determining said state from a glance at the vector. This really isn't a danger anymore. So, with the horse trading, we could now represent up to 32 code kinds. BUG= Committed: https://crrev.com/25d48ec37fd3b8a6f22008df0c24530b98ab3e63 Cr-Commit-Position: refs/heads/master@{#31666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -41 lines) Patch
M src/code-stubs.h View 8 chunks +8 lines, -8 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/ic/ic.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M src/objects.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 5 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Benedikt, this CL should aid our IC plans, both before and after the Christkindlmarkt ...
5 years, 1 month ago (2015-10-29 17:06:15 UTC) #2
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-10-29 18:55:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427803003/1
5 years, 1 month ago (2015-10-29 20:31:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 20:32:45 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 20:33:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25d48ec37fd3b8a6f22008df0c24530b98ab3e63
Cr-Commit-Position: refs/heads/master@{#31666}

Powered by Google App Engine
This is Rietveld 408576698