Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1427743004: exo: Add support for wl_drm version 2 to wayland bindings. (Closed)

Created:
5 years, 1 month ago by reveman
Modified:
5 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@wayland-drm-third-party
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Add support for wl_drm version 2 to wayland bindings. BUG=549781 TEST=exo_unittests --gtest_filter=DisplayTest.CreatePrimeBuffer Committed: https://crrev.com/f2357f3128ded8e895eb2380a792947e47295425 Cr-Commit-Position: refs/heads/master@{#360990}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Total comments: 4

Patch Set 7 : fix unit test and nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -1 line) Patch
M components/exo.gypi View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M components/exo/display.h View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
M components/exo/display.cc View 1 2 3 4 5 2 chunks +35 lines, -0 lines 0 comments Download
M components/exo/display_unittest.cc View 1 2 3 4 5 6 2 chunks +33 lines, -0 lines 0 comments Download
M components/exo/wayland/BUILD.gn View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 1 2 3 4 5 6 4 chunks +126 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
reveman
This depends on https://codereview.chromium.org/1423563007.
5 years, 1 month ago (2015-11-20 05:36:22 UTC) #3
piman
lgtm https://codereview.chromium.org/1427743004/diff/100001/components/exo/display_unittest.cc File components/exo/display_unittest.cc (right): https://codereview.chromium.org/1427743004/diff/100001/components/exo/display_unittest.cc#newcode71 components/exo/display_unittest.cc:71: base::ScopedFD(native_pixmap_handle.fd.fd), buffer_size, drm_format, drm_format? Doesn't CreatePrimeBuffer take a ...
5 years, 1 month ago (2015-11-20 19:40:34 UTC) #4
reveman
https://codereview.chromium.org/1427743004/diff/100001/components/exo/display_unittest.cc File components/exo/display_unittest.cc (right): https://codereview.chromium.org/1427743004/diff/100001/components/exo/display_unittest.cc#newcode71 components/exo/display_unittest.cc:71: base::ScopedFD(native_pixmap_handle.fd.fd), buffer_size, drm_format, On 2015/11/20 at 19:40:34, piman (slow ...
5 years, 1 month ago (2015-11-20 20:53:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427743004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427743004/120001
5 years, 1 month ago (2015-11-20 20:54:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/144111)
5 years, 1 month ago (2015-11-20 21:50:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427743004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427743004/120001
5 years, 1 month ago (2015-11-20 22:09:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/99255)
5 years, 1 month ago (2015-11-20 23:38:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427743004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427743004/120001
5 years, 1 month ago (2015-11-20 23:41:03 UTC) #16
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 1 month ago (2015-11-21 02:46:38 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 02:47:34 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/f2357f3128ded8e895eb2380a792947e47295425
Cr-Commit-Position: refs/heads/master@{#360990}

Powered by Google App Engine
This is Rietveld 408576698