Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1427733002: Reland of Suppress memory leak from WebGraphicsContext3DCommandBufferImpl (Closed)

Created:
5 years, 1 month ago by oshima
Modified:
5 years, 1 month ago
Reviewers:
erikchen, reveman
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Suppress memory leak from WebGraphicsContext3DCommandBufferImpl (patchset #1 id:1 of https://codereview.chromium.org/1411643004/ ) Reason for revert: Couldn't do speculative revert due to conflict. I'll look into other CLs first. Original issue's description: > Revert of Suppress memory leak from WebGraphicsContext3DCommandBufferImpl (patchset #1 id:20001 of https://codereview.chromium.org/1428643002/ ) > > Reason for revert: > for speculative revert > > Original issue's description: > > Suppress memory leak from WebGraphicsContext3DCommandBufferImpl > > > > BUG=548039 > > TBR=erikchen@chromium.org,reveman@chromium.org > > > > Committed: https://crrev.com/fb1a837f472bc9f004ccb8fa1c0d5f83acbeba4e > > Cr-Commit-Position: refs/heads/master@{#356444} > > TBR=erikchen@chromium.org,reveman@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=548039 > > Committed: https://crrev.com/eca678585491d769a57eb41b34cb0b79a8e050f0 > Cr-Commit-Position: refs/heads/master@{#356524} TBR=erikchen@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=548039 Committed: https://crrev.com/3dc5ef2ff48fa435753e97cb431fa5360aa3355a Cr-Commit-Position: refs/heads/master@{#356525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
Created Reland of Suppress memory leak from WebGraphicsContext3DCommandBufferImpl
5 years, 1 month ago (2015-10-28 07:47:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427733002/1
5 years, 1 month ago (2015-10-28 07:47:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 07:48:26 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 07:49:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dc5ef2ff48fa435753e97cb431fa5360aa3355a
Cr-Commit-Position: refs/heads/master@{#356525}

Powered by Google App Engine
This is Rietveld 408576698