Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1427683004: disable more avx2 functions that dont link in chrome (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

disable more avx2 functions that dont link in chrome libyuv builds/runs, but when integrated into chromium, produces link errors. unclear why but this disables affected functions. will followup with re-enabling them once the root cause in the runtime error is found. TBR=harryjin@google.com BUG=libyuv:522 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/72a9e282ecf848a5578f1e5983f0bb56a6c24fa6

Patch Set 1 #

Patch Set 2 : reenable argb565 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M include/libyuv/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M source/row_any.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
fbarchard1
5 years, 1 month ago (2015-11-10 01:20:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
72a9e282ecf848a5578f1e5983f0bb56a6c24fa6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698