Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2202)

Issue 1427683002: [Android] Add option to override test in-progress timeout for amp. (Closed)

Created:
5 years, 1 month ago by mikecase (-- gone --)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add option to override test in-progress timeout for amp. We are adding test sharding on AMP which should fix most of our test run timeouts we are hitting. However, there are some devices which appurify only has 1 of. If we want to run specifically on that device, we won't be able to shard the test, and will therefore sometimes need to override the test in-progress timeout. BUG= Committed: https://crrev.com/ddfa35d36a883e1b0c4cae63871de387bca89d9a Cr-Commit-Position: refs/heads/master@{#356472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/android/pylib/remote/device/remote_device_environment.py View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mikecase (-- gone --)
5 years, 1 month ago (2015-10-27 22:23:51 UTC) #2
rnephew (Reviews Here)
On 2015/10/27 22:23:51, mikecase wrote: lgtm as long as the bots aren't using --remote-device-file to ...
5 years, 1 month ago (2015-10-27 22:29:49 UTC) #3
mikecase (-- gone --)
On 2015/10/27 at 22:29:49, rnephew wrote: > On 2015/10/27 22:23:51, mikecase wrote: > > lgtm ...
5 years, 1 month ago (2015-10-27 22:43:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427683002/1
5 years, 1 month ago (2015-10-27 22:45:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 01:14:33 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 01:16:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddfa35d36a883e1b0c4cae63871de387bca89d9a
Cr-Commit-Position: refs/heads/master@{#356472}

Powered by Google App Engine
This is Rietveld 408576698