Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1427663002:
Make SK_PREFETCH work on Windows too. (Closed)
DescriptionMake SK_PREFETCH work on Windows too.
- Use _mm_prefetch() if available, e.g. with MSVC.
- Some other tidying up.
No public API changes.
TBR=reed@google.com
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/6885a1e7c04450c0377a85d3ec8698badc58cbea
Patch Set 1 #Patch Set 2 : actually, SSE1 #
Total comments: 2
Messages
Total messages: 16 (9 generated)
Description was changed from ========== Make SK_PREFETCH work on Windows too. This uses _mm_prefetch() if available, which also works with MSVC. Some other tidying up. BUG=skia: ========== to ========== Make SK_PREFETCH work on Windows too. This uses _mm_prefetch() if available, which also works with MSVC. Some other tidying up. No public API changes. BUG=skia: ==========
Description was changed from ========== Make SK_PREFETCH work on Windows too. This uses _mm_prefetch() if available, which also works with MSVC. Some other tidying up. No public API changes. BUG=skia: ========== to ========== Make SK_PREFETCH work on Windows too. - Use _mm_prefetch() if available, i.e. with MSVC. - Some other tidying up. No public API changes. BUG=skia: ==========
Description was changed from ========== Make SK_PREFETCH work on Windows too. - Use _mm_prefetch() if available, i.e. with MSVC. - Some other tidying up. No public API changes. BUG=skia: ========== to ========== Make SK_PREFETCH work on Windows too. - Use _mm_prefetch() if available, e.g. with MSVC. - Some other tidying up. No public API changes. BUG=skia: ==========
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427663002/20001
mtklein@chromium.org changed reviewers: + senorblanco@chromium.org - mtklein@google.com
LGTM, but you'll probably need (reed|bsalomon) for this "API" change. https://codereview.chromium.org/1427663002/diff/20001/include/core/SkPostConf... File include/core/SkPostConfig.h (right): https://codereview.chromium.org/1427663002/diff/20001/include/core/SkPostConf... include/core/SkPostConfig.h:301: #elif defined(__GNUC__) We don't need "define(__clang__) ||" here anymore?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mtklein@google.com changed reviewers: + mtklein@google.com
https://codereview.chromium.org/1427663002/diff/20001/include/core/SkPostConf... File include/core/SkPostConfig.h (right): https://codereview.chromium.org/1427663002/diff/20001/include/core/SkPostConf... include/core/SkPostConfig.h:301: #elif defined(__GNUC__) On 2015/10/27 20:03:20, Stephen White wrote: > We don't need "define(__clang__) ||" here anymore? Nah, Clang defines __GNUC__. Seemed confusing to leave it there, as if to suggest Clang didn't define __GNUC__. (Usually I find checking for __clang__ is only useful when Clang needs to do something differently than GCC. Pretty rare.)
Description was changed from ========== Make SK_PREFETCH work on Windows too. - Use _mm_prefetch() if available, e.g. with MSVC. - Some other tidying up. No public API changes. BUG=skia: ========== to ========== Make SK_PREFETCH work on Windows too. - Use _mm_prefetch() if available, e.g. with MSVC. - Some other tidying up. No public API changes. TBR=reed@google.com BUG=skia: ==========
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427663002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/6885a1e7c04450c0377a85d3ec8698badc58cbea |
